Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] leds: an30259a: add a check for devm_regmap_init_i2c
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, <linux-leds@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20191016125403.23359-1-hslester96@gmail.com>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <1f4282aa-edb2-2683-bfff-8805a972710b@ti.com>
Date:   Wed, 16 Oct 2019 09:33:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191016125403.23359-1-hslester96@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Chuhong

On 10/16/19 7:54 AM, Chuhong Yuan wrote:
> an30259a_probe misses a check for devm_regmap_init_i2c and may cause
> problems.
> Add a check and print errors like other leds drivers.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
>    - Use goto exit instead of return to destroy the mutex when failed.
>
>   drivers/leds/leds-an30259a.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c
> index 250dc9d6f635..82350a28a564 100644
> --- a/drivers/leds/leds-an30259a.c
> +++ b/drivers/leds/leds-an30259a.c
> @@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client)
>   
>   	chip->regmap = devm_regmap_init_i2c(client, &an30259a_regmap_config);
>   
> +	if (IS_ERR(chip->regmap)) {
> +		err = PTR_ERR(chip->regmap);
> +		dev_err(&client->dev, "Failed to allocate register map: %d\n",
> +			err);
> +		goto exit;
> +	}
> +

Reviewed-by: Dan Murphy <dmurphy@ti.com>


>   	for (i = 0; i < chip->num_leds; i++) {
>   		struct led_init_data init_data = {};
>