Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7517060ybp; Wed, 16 Oct 2019 09:49:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFVV+ST20GnO2HlmBk5EnmDKWV0JpGdLhIhN4PshMTYcgpyaCmDQO7nJQHTCl7SPW8k8OH X-Received: by 2002:a17:906:fad7:: with SMTP id lu23mr41839613ejb.211.1571244547097; Wed, 16 Oct 2019 09:49:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571244547; cv=none; d=google.com; s=arc-20160816; b=L5ZnDlhbugUwa+ll+sFTwcCBtO/qqrzoVXkVYhMqrV89aOIOCXaTUl8dJt9wuQ8YQC ubhCMczRkGzY1pF8SRM3ot4OIvc5kfa3karbnVOeWWDurTOVZfXNFSk7B5z/EFvKVyzH zG+cdGjncUhotsMnNrM/3h7BiwvLPgBqgKBkBE/EXa9/6qLPD9HL59cFJk7VUoQvgBOj u1tkCADefoqawitQyfZyxvKN+gJ8Vo3YxctWHwF5o/oCrEuRofhY7HErRTvotaQbv6kV U5lWBtzRdINK/GD4hOdT1EwM1GErq2lqzu23KJcyb7FzK0dFUB2i4piush/KM7UHJRL1 O/Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KDsBMor53+XkIcVqyL5BlbrtKoEP3wH7QypdRSgRvVI=; b=mcRt1hVLpdkH8BSUUk1u/S3ZOpgPYY67b9g3szcdX8Cseeu3kKDcsTR78bKznNf8AV x0GuGqYXdb0SY1Yuvu6SBqNvGq6SZ/fYV8ROHI4ygWaMg58BVIlMycDl1bWPzj9N4jxH Yf4rCSNRrP3s2HBHYQMan58jM8+hcaQ3a1Cci2/FDmcg8iFf1O1tv/QKttxIqRtzwqMT BFBGfTuL4t2hAvFMuCegAw2XkTpH5TO+JVF2qoXbs0XgTRAfE4ko1T9tuFnvY6oSWgwu Ed3LyRTZN9HSJ4be1O1gzAMbFjueRzqf3QLpyWFcjJzSfSyiQfP66VriPM7GQt4Havxm wN4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Ub3eVord; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rn4si15559970ejb.251.2019.10.16.09.48.42; Wed, 16 Oct 2019 09:49:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Ub3eVord; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393378AbfJPPDH (ORCPT + 99 others); Wed, 16 Oct 2019 11:03:07 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:58970 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbfJPPDG (ORCPT ); Wed, 16 Oct 2019 11:03:06 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9GEtstN133220; Wed, 16 Oct 2019 15:02:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=KDsBMor53+XkIcVqyL5BlbrtKoEP3wH7QypdRSgRvVI=; b=Ub3eVordpT1fop0PM0nm+Lska27+WVcvGRrK9ltkAUQpF9Kyx4x1GS8FDrxsFI+ybxEC fW1kz5l4BF1P1oCC9XVDx/YP2GQpADFCmAA64lfX1iHJgwAyHEopAJdnnBK/aRiFUA5R ILG3jls+7HxHoJDTOf3su3X1OfYnmBKHP/0cJ0f57hJ6YsOBlVbjgZgETndgWZ4UZM+w SKZ2yn8X7BsfM+uAjTxQHWENtcNgJyk3ARqBP7UO8U3jbXfvLKLulVyiiX/LKopHvJzI sxMDWQGkVQe1i9bd/rYEfB226PVVmJKxSECwoJXdSEII+QcxJXsJoCSy+GBGzyrdbAxs Mg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2vk6sqqms6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2019 15:02:37 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9GEmLu3030127; Wed, 16 Oct 2019 15:02:36 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2vnxv9uh39-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2019 15:02:36 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9GF2USv020399; Wed, 16 Oct 2019 15:02:31 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 Oct 2019 15:02:30 +0000 Date: Wed, 16 Oct 2019 18:02:12 +0300 From: Dan Carpenter To: Chuhong Yuan Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen , Stefan Popa , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack , Jonathan Cameron Subject: Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get Message-ID: <20191016150212.GD24678@kadam> References: <20191016142540.26450-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016142540.26450-1-hslester96@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9412 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910160129 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9412 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910160129 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 10:25:40PM +0800, Chuhong Yuan wrote: > ad9834_probe misses a check for devm_clk_get and may cause problems. > Add a check like what ad9832 does to fix it. > > Signed-off-by: Chuhong Yuan Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter