Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 Oct 2019 13:44:11 -0400 (EDT)
Message-Id: <20191016.134411.315258296003464370.davem@davemloft.net>
To:     ben.dooks@codethink.co.uk
Cc:     daniel@iogearbox.net, linux-kernel@lists.codethink.co.uk,
        ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        jakub.kicinski@netronome.com, hawk@kernel.org,
        john.fastabend@gmail.com, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bpf: add static in net/core/filter.c
From:   David Miller <davem@davemloft.net>
In-Reply-To: <e3e81678-6c58-191b-3514-629f5f94def2@codethink.co.uk>
References: <e947b15d-1d70-39d9-3b28-0367a3f0f4c0@codethink.co.uk>
        <20191016131020.GE21367@pc-63.home>
        <e3e81678-6c58-191b-3514-629f5f94def2@codethink.co.uk>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Wed, 16 Oct 2019 14:11:52 +0100

> Hmm, your config it does, I get /none/ of these warnings.
> 
> I guess a lot of this is being built whether or not is then used.

When you are making changes like this, unless you have done a full grep
over the tree and are %100 sure it is unrefrenced you should do at
a minimum an allmodconfig build.

Otherwise by definition you are not testing the build of this change.