Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp933515ybp; Thu, 17 Oct 2019 05:49:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwGNTO8AJg9zmqm2NdmDUxEMVQ+1ZNWdVdtUpHGPL9mi9iLWskwKvjK/oi1a2JHHJ3aS6I+ X-Received: by 2002:a17:906:a986:: with SMTP id jr6mr3271440ejb.158.1571316596251; Thu, 17 Oct 2019 05:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571316596; cv=none; d=google.com; s=arc-20160816; b=uVCxDdwgKfHP7DlUHHm56nAysqA4TZwn7h8Qd2gbislL4GHhFMcMOvFHoVUMCnJSfX WCZRf/STrvtAcLrj/Y03YdcDjPT1XGOiIAhnvM1GiA7MNSz63NoMc+VcXg3pL3Vg7w0p pOB0MZCnjNdQG4vop0UIz/0OaukuRZcAgZ6EikLNYcignd7BessyJXROSl3jax8BdhaG wkXsHFfTYRvXJ8TjElE1BckTyA79vecKCz7Qiw4aoKWaHq/SOS1rnOjEwp+/EQd5eOXF AQRELzVVRuEpjuO5ZbKy7dpKkoKyeaZln0xEBBDgOwT4v37TZzgo3xxJM8vBXjPdE59j 5tAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=IrPJN3Hx8SZusj3UY1TGT95fH6Hjv9mvFmPw4oRLj54=; b=PAdAB/BKU3kvayRNoWifCiQmDRDy5MUhe8OcuBV70CN3dF+/TqJ3qRohQbIhMKWnFR u1fE477SwaAZ9L8COWhLIplwbBi9+kBLSfiyL7CaPm3+gil3G+jgsCqmTK+XHrlTsxFJ TeXAqUi+CspnuYdyzIjyWBr4TFKFR7INehpn+dBZIFVFjJOYpPeqO2gU/SqDUbq9tEDv 2SFAwc6KWohG0CRGRtKpmS2k02Du2mOv6rdvo61dM5IZZzSOiu3+4R0I/+rz69LzpFFr IxWxTwjdbdZa5k/ZvTHTK1rJiv0fn+FQv1kHeIwWrSI9jqXiVqqCJAJPBr/sbntMcwpG UkQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oc24si1201682ejb.254.2019.10.17.05.49.33; Thu, 17 Oct 2019 05:49:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390472AbfJPRuG (ORCPT + 99 others); Wed, 16 Oct 2019 13:50:06 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390071AbfJPRuF (ORCPT ); Wed, 16 Oct 2019 13:50:05 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C43EB14239BEE; Wed, 16 Oct 2019 10:50:04 -0700 (PDT) Date: Wed, 16 Oct 2019 13:50:03 -0400 (EDT) Message-Id: <20191016.135003.672960397161023411.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: tanhuazhong@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations From: David Miller In-Reply-To: <20191016101943.415d73cf@cakuba.netronome.com> References: <1571210231-29154-1-git-send-email-tanhuazhong@huawei.com> <20191016101943.415d73cf@cakuba.netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Oct 2019 10:50:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 > On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: >> This patch-set includes some bugfixes and code optimizations >> for the HNS3 ethernet controller driver. > > The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4 > should be a separate series targeting the net tree :( Agreed, there are legitimate bug fixes. I have to say that I see this happening a lot, hns3 bug fixes targetting net-next in a larger series of cleanups and other kinds of changes. Please handle this delegation properly. Send bug fixes as a series targetting 'net', and send everything else targetting 'net-next'.