Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <38f39e9e77cb4bc809a15da45d988f33cb0f7f00.camel@gmail.com>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc
From:   Tuowen Zhao <ztuowen@gmail.com>
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     lee.jones@linaro.org, linux-kernel@vger.kernel.org,
        AceLan Kao <acelan.kao@canonical.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
Date:   Wed, 16 Oct 2019 11:58:48 -0600
In-Reply-To: <20191016125615.GI16384@42.do-not-panic.com>
References: <20191014153344.8996-1-ztuowen@gmail.com>
         <201910150232.F7RTW83B%lkp@intel.com>
         <c4bcdf14e0a60a679429eebd439b2380d97dafe9.camel@gmail.com>
         <20191015074434.GU32742@smile.fi.intel.com>
         <20191016125615.GI16384@42.do-not-panic.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-10-16 at 12:56 +0000, Luis Chamberlain wrote:
> Indeed, can you add that? If you are not comfortable the way to leave
> behind lazy architectures is the HAS_FOO feature and then have your
> driver require that or depend on the archs that support this. This
> allows non-lazy architecturess to move forward with life.
> 
>   Luis

Upon close examination, the issue seems easy to fix. Going to submit a
new set shortly.

sparc64 and hexagon don't have ioremap_uc defined. Hexagon also doesn't
have ioremap_wc but didn't report an issue before so devm_ioremap won't
have an problem.

Interestingly tho, majority of the archs include <asm-generic/io.h>,
thus having prototypes. These two archs and a few others don't. I'm
wondering if including the prototypes is actually the recommended
practice.

Tuowen