Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp986408ybp; Thu, 17 Oct 2019 06:30:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbqwctpVTm6DKS3T6HrInxSeteAi6SQ+cmcSl1LRHnfyPolS3S8vhGuU2/vd3GAxqY/FpN X-Received: by 2002:a05:6402:51a:: with SMTP id m26mr3748202edv.298.1571319027019; Thu, 17 Oct 2019 06:30:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571319027; cv=none; d=google.com; s=arc-20160816; b=Nn8s9jOL9a1j5OdDWFE1YKF+SF5YBDl/249QpXatWVpLV1aV2vmzSVlQtz1fBdR+5n FAVgzul1dn1humHpUC0Jk6oK6yruZMnaCn7Lc0souqTWJycPuc/zD1B8MGcl/BVnRpol jA2m6/N3Z7g58Q3BWrnPDPSvfbWBJ1fOblBaZzluhvcqAjMdk1eIfRcQYLWR2iVsJAlD AvCy0CbwBOTSCZ+lO8MPP8tqByiVI5jKiyxbrL30A00WMHjC7Ha4dhifbkQzAWLSTncD qUTUE/B/1AOlyYSUyTusyauinrIU7bdCQD2O8vOwlKVv8KrphH4dqU4H+xroSigysAgo p0xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EPkO+6FKPRMlH5FDzY1dS/azBVdGxhY85XXnmRXnlUU=; b=eFPTWMDPRFe5kygpGkLr2PMdz2D/He4+sooGfrYDdH2aUbS3vZS9JXJ4uFfVPwH/e4 rJ3LS5XdtYFnRSQygbDlspjIJkF+JNDnjPZeaRSrfRdOqk0fqhJ+waAq/dZToZ+ZISwk tg4jJQ9oC9JEJn4LlaU8fRx0W07/3bE6tJhCk4Ijm03RMiSkjQBNJ0qJ7EUqWkfSAgiO u6Muihbc3+eZEU0ECDARVqEy+DLjvZM+Y/E+Dt+Y2L5R5YaKhkIGwh6PMfwCSN2cUqDn +GvC3Vt0CuEpqHHeYRI19218KTJkleHy2z+ybgbHtobZw/sDcDwFB7NmGFOLFgNfi/xm fgGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si1340918ejz.391.2019.10.17.06.30.03; Thu, 17 Oct 2019 06:30:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394709AbfJPUOS (ORCPT + 99 others); Wed, 16 Oct 2019 16:14:18 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:51165 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfJPUOS (ORCPT ); Wed, 16 Oct 2019 16:14:18 -0400 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 79131240004; Wed, 16 Oct 2019 20:14:16 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: Benson Leung , Enric Balletbo i Serra , Guenter Roeck , linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 1/2] rtc: cros-ec: remove superfluous error message Date: Wed, 16 Oct 2019 22:14:13 +0200 Message-Id: <20191016201414.30934-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core now has error messages in case of registration failure, there is no need to have other messages in the drivers. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-cros-ec.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c index 6909e01936d9..da209d00731e 100644 --- a/drivers/rtc/rtc-cros-ec.c +++ b/drivers/rtc/rtc-cros-ec.c @@ -351,11 +351,8 @@ static int cros_ec_rtc_probe(struct platform_device *pdev) cros_ec_rtc->rtc = devm_rtc_device_register(&pdev->dev, DRV_NAME, &cros_ec_rtc_ops, THIS_MODULE); - if (IS_ERR(cros_ec_rtc->rtc)) { - ret = PTR_ERR(cros_ec_rtc->rtc); - dev_err(&pdev->dev, "failed to register rtc device\n"); - return ret; - } + if (IS_ERR(cros_ec_rtc->rtc)) + return PTR_ERR(cros_ec_rtc->rtc); /* Get RTC events from the EC. */ cros_ec_rtc->notifier.notifier_call = cros_ec_rtc_event; -- 2.21.0