Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1018260ybp; Thu, 17 Oct 2019 06:57:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkeA7Re02+030VppHHSu/C1owCQMGQ76EJEqfFJqB01UoIdZfXC0Nhxg26+TtZireEW4aQ X-Received: by 2002:aa7:d2cf:: with SMTP id k15mr3846495edr.208.1571320654344; Thu, 17 Oct 2019 06:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571320654; cv=none; d=google.com; s=arc-20160816; b=SpuWFT0hvMxIfMpx9L52xhwBo6m85P7IKj7CgHh7DNJnbTBKGeEe0Mxfbu46dwMCLW v494CXjCvhNhprg6f9t0raYFC8MZ+6oz5Pr3j/9LoGJpQoWPpMvnuiSu0l7saS4pANbc OngydJSBhol5WCIlR/X+XSxV5a+WKVBJhc+L3Sbu6GCfXBbCkYSnQJurKvqYCcnK87pX ve8gIGYdSY0RyiPtIg23Tk+qMIazxXl2qGM10KR7khX4hlVM3hC48KoYs44grWAfD26s BIBg7/okN/KqLAWH+DST5nfvx7UToWaINTiJt6JLJGUHk3PAD6hWRVD1OUPG03fvDMZs Tb9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/yjgZhJlzmYmxj7+A0FInNB+01Y4Ffyd19ePmcPESes=; b=ZN2i0aTSJsxfETZqXbu0bFSGUDHHliccI56aPfT7mkGZJexN86tijoT7zWFi/cQ1Se u8UdhBdMDsBYFLbPpbcj/4WrHPKhBvcWA97M5dmtYtW4z/AhGf2I0j1ukjOnih1ZFoc+ paNWurZScf1Rf5K2bGJTbsgnpWHooO+ne2ZcfJ+BxoQMvBx+NIsJzHSDr6ZInl/x9PRm 77piMy0riBwj5nU3wKNl6qQ5eGu2NnfhTFiZkxoBYzeVpchSBnsIRms88zwAIzK8Vjr/ 5olVoKGoEZTZx8NBor2bI6eK0FbYNhT9EGt4KwPzzfmZna1ynK9Lfvi9Rm0VMZmX7NyG vkww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jddw4T+X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oe23si1397113ejb.199.2019.10.17.06.57.10; Thu, 17 Oct 2019 06:57:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jddw4T+X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437418AbfJPVHm (ORCPT + 99 others); Wed, 16 Oct 2019 17:07:42 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35086 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437412AbfJPVHm (ORCPT ); Wed, 16 Oct 2019 17:07:42 -0400 Received: by mail-pg1-f194.google.com with SMTP id p30so15027617pgl.2 for ; Wed, 16 Oct 2019 14:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/yjgZhJlzmYmxj7+A0FInNB+01Y4Ffyd19ePmcPESes=; b=Jddw4T+X+HzroDym+MeSAk5gk5lWXCnojaKghw8XY6Z55upOq2W8SWVHhWznezoxXc hMoZyd8eWOmujsE+cyhRZ3zEg6fF9HVONioPaDT9czYgKkYQ9/bmWNlGQCDsjHX7teXz 3VhxF1cFnBYNFRvFsNzEoF+RGB7hFgJ+DgBjh2T+jsdqo9kty/F9a25rIK9ket5saIgu dm5aad3yQ45ZhmBUzMA99/wGMLwk18bREjssFWvt2MKwhlseSYYGhQKdxhMcYvnR/HmS ApmuZpoKTNlblPtje+Nt8fO+bn0M+ibv5xcc0ifZVbw2VCTonaLOxfJNFpY6AfDU4/7q eZ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/yjgZhJlzmYmxj7+A0FInNB+01Y4Ffyd19ePmcPESes=; b=ug3ZWnInPSgCO6oM3sdSHD/ojVDCbsLrm3DHZvlmWAFWC49RHaOKhWtzn4wGcmMs3Z hBhXz8LeMHuKB9MAnm5oWpsLmitEtFGrflY1ajiCjh6L+WNUbrIMWNGot4U3fluydOfT 7kW2IXfc8g0h85nGSsUFpSJ0vU7K/QoRWk6TRr6Z6MdsPnjFfWzyrstPTwQcDy6snPVW cH+ZM/0AvJIQh1FneYJH15CbeIZdlUQfK3BZCau+UlV3MZQM6QxT7CAZlXrQJ8058K7F fFvgEJ+uBzlAwKfp8iQDncgWqDgqyuwjCHBJ/xIRbWESCYcHYLvhMdNEp6AvbGRqax2C cIfA== X-Gm-Message-State: APjAAAWT8/3HGiC/n/Q/JX8WdT98VtM0cM1T6P6+ZXC8CedAPWLddb53 E+tt2Fnfu84l2FZkaUk/DzI= X-Received: by 2002:a63:dd17:: with SMTP id t23mr198930pgg.134.1571260060600; Wed, 16 Oct 2019 14:07:40 -0700 (PDT) Received: from localhost.localdomain (155-97-232-235.usahousing.utah.edu. [155.97.232.235]) by smtp.googlemail.com with ESMTPSA id x11sm11613226pja.3.2019.10.16.14.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 14:07:40 -0700 (PDT) From: Tuowen Zhao To: lee.jones@linaro.org, linux-kernel@vger.kernel.org Cc: andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, mcgrof@kernel.org, davem@davemloft.net, Tuowen Zhao Subject: [PATCH v5 3/4] mfd: intel-lpss: use devm_ioremap_uc for MMIO Date: Wed, 16 Oct 2019 15:06:29 -0600 Message-Id: <20191016210629.1005086-4-ztuowen@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016210629.1005086-1-ztuowen@gmail.com> References: <20191016210629.1005086-1-ztuowen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci in MTRR. This will cause the system to hang during boot. If possible, this bug could be corrected with a firmware update. This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings by forcing the use of strongly uncachable pages for intel-lpss. The BIOS bug is present on Dell XPS 13 7390 2-in-1: [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining 4000000000-7fffffffff : PCI Bus 0000:00 4000000000-400fffffff : 0000:00:02.0 (i915) 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci) Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485 Cc: Tested-by: AceLan Kao Signed-off-by: Tuowen Zhao Acked-by: Mika Westerberg Acked-by: Andy Shevchenko Acked-for-MFD-by: Lee Jones --- drivers/mfd/intel-lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c index bfe4ff337581..b0f0781a6b9c 100644 --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c @@ -384,7 +384,7 @@ int intel_lpss_probe(struct device *dev, if (!lpss) return -ENOMEM; - lpss->priv = devm_ioremap(dev, info->mem->start + LPSS_PRIV_OFFSET, + lpss->priv = devm_ioremap_uc(dev, info->mem->start + LPSS_PRIV_OFFSET, LPSS_PRIV_SIZE); if (!lpss->priv) return -ENOMEM; -- 2.23.0