Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1041279ybp; Thu, 17 Oct 2019 07:14:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzw618dPpgcoT062G2WmcQLO6z8byr2jzbEp5+CSBYuwObtX6or6fIttrILhMnC/YfPg2XG X-Received: by 2002:a17:906:2410:: with SMTP id z16mr3725566eja.120.1571321679606; Thu, 17 Oct 2019 07:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321679; cv=none; d=google.com; s=arc-20160816; b=eWvsbr5hW015TVa4MtRdeOUORT0KpBVlc4jMmJHpIoLRwmssnc88/knp+sZwuEiZyb HKpY8VhthRMqCJpJtcEvke5mbRzqTPZ0s927sJ3pPdqlSfSKrhUYl9u1dfKstuae9P42 8YNVwVXn77M8NKFJXBd0zNQc7oJbyt2az/jEK9aNDqOK3Eg5s6Tz85r990oqzQjGBUeX G2VQVGsfLnMdAnFfE08mBrYpkLsQND2TYT4CGlUApOqw6X9e/6lZRZ56i3Edigw8Y08p SXEZU9QuxN+AsoHebHYsrlYh/deQORxh7DTKomUn22ATfoO4rJeFgCUhhrC51vqv7fOB Copg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Y3s474KKEogoMcYXeU/NlnUm/opDvj5JGRg3tvw0cgQ=; b=VmkKnATa/17UkcQdeMGlBt+BOLU6yvRqADEHEgOOrNC2GMqgwKGy8ORPdKmhdViT9N cGWhmuTgMFLqaKABI46PyfchmdcQVkSwviKb/XRB6LgTnhxeEE2Ekt8gzxmy/O+fYs56 83yZrerRSxSp5aQN/KXt3wobysXKZaIp1YKUYHT+EfPmg+gtr1ZLUTQSuASLmqDzjc+u Rs2MTXusk16OOmW8SLezw9+hku+MWC132AOtRpTZI65LmU+UrOzf7bmmnCLbi/OxklRA pIYTnoFdB/4ru20lnwrrMd/pfWA6/y6CTELYR2rf93XZVLBIYSGhfd3dJupkzvGsWPrC sYOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=P3gzKxAl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 13si1868036edw.357.2019.10.17.07.14.16; Thu, 17 Oct 2019 07:14:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=P3gzKxAl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394886AbfJPVxm (ORCPT + 99 others); Wed, 16 Oct 2019 17:53:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:42518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437526AbfJPVxd (ORCPT ); Wed, 16 Oct 2019 17:53:33 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E18E218DE; Wed, 16 Oct 2019 21:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262812; bh=6kvh2ljFqUDYi5wwuIe97TZ/HrGcR9V7uAH6Lgc/6cA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P3gzKxAlBXr8Y7VpOH7JvDr7JrfHOhskXEW5Yhjy30+BQtudBolHyT8MsniNkYlaZ Ksf3D+z5Y6cI5MJ2kX62+qYVERXWeVm0nMlJ5SIQvIpHrCqJ7nLdAmEKbXtHwaV4yK LSWfULkO9OkKWZUERPTnroKzSMKIJ0S6MlYSjDPg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com, Johan Hovold , Oliver Neukum Subject: [PATCH 4.4 55/79] USB: microtek: fix info-leak at probe Date: Wed, 16 Oct 2019 14:50:30 -0700 Message-Id: <20191016214818.832009341@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 177238c3d47d54b2ed8f0da7a4290db492f4a057 upstream. Add missing bulk-in endpoint sanity check to prevent uninitialised stack data from being reported to the system log and used as endpoint addresses. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/20191003070931.17009-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/image/microtek.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -724,6 +724,10 @@ static int mts_usb_probe(struct usb_inte } + if (ep_in_current != &ep_in_set[2]) { + MTS_WARNING("couldn't find two input bulk endpoints. Bailing out.\n"); + return -ENODEV; + } if ( ep_out == -1 ) { MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );