Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1041920ybp; Thu, 17 Oct 2019 07:15:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5AgY94gAZ3jZU7h/X2JWxFPkLXRqwLy8oob5IDNQXdpcS25Yf9qCV0PqX3i0nQEI9uRrY X-Received: by 2002:a50:f7c7:: with SMTP id i7mr3992746edn.81.1571321708668; Thu, 17 Oct 2019 07:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321708; cv=none; d=google.com; s=arc-20160816; b=dg5tUQMY1erYtZp7bP9hp/sxHyQmN74Ad3HOoVZ/4hKKquxV0dNBdv51hvtUKwlAdI LcfSMYnr6elgHsosGlZQGpViOq7kXO3vpXKj+gKLi8byAurYtQn9pr9hDyd4E1u06HDT asrqV/Fdjxp5G6S4Frcz6XJxucGquYTVLdGOSLVJBUtXBmvmJS334jQ/5g0HKVo/Rq/t TmwdzSgJ3A+E+otzd7ovxnIT9Kmn9/I0et5l8kzT0ixKDOwzgRW0Cmc8Lk3GDZ1T16a/ 24hyFOiutj+BiU9dRWsVTpBitdspSsJvYMfYxvbqbUduZAQAD3k6NmtZ8udExVd+gnn+ ENZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=V0d6sa5m8vENwrNvpu75mRvnJIArjFBHA9UxMxOX58k=; b=riRsn5Kl/V1uwU0lVxdM+sTdAg2ALcBM+Lt8J3PZLhbyDYtydbbt+Vfwx6qNrndjch INZS+gmYwySwYqADrNta6XowLdrEziLB5rXJOGj9qqkK8Xp7QppgJ7FJ2w1yhF6d3ebX HQIdXstdkNfynyRWxrLvzUJq79Stu8kgj1lyg6ux0UF9k39kpDNgcLs3IxH5pa5a6YEy UawrlSrh5BNrEdDJbONuQf3Uw3rLiqzDDESDdBKizwP2Z8fYfOyVG4xJvEioQgwTKlRI NnJW+w4hbnquO13XJ3WU1xXudyKLuE8GyX7c7+g5mebRlLdS18B1/ZktPUnV42MCyuW1 Pw/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fXIxeAcZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t9si1429812ejr.29.2019.10.17.07.14.45; Thu, 17 Oct 2019 07:15:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fXIxeAcZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437586AbfJPVxq (ORCPT + 99 others); Wed, 16 Oct 2019 17:53:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437541AbfJPVxf (ORCPT ); Wed, 16 Oct 2019 17:53:35 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61C2021925; Wed, 16 Oct 2019 21:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262814; bh=JTXGVBsdPTWFjOc1petNnhXeWZTP+Ad+9jQrGAdFgko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fXIxeAcZuJf0MOuOHzFxgG6DiefktyP9EXbnhH/g9pdyYEdYq1ZPiOgm8b9a77tfL 8ROtrSR3L2Rj+85n9pMdSEIP4agPCtLlP53sa9tyAmaWj3PP3ZTzEtO0+FK14QiRCl 75+nC4588vUI9y7nItIB4hjxBtZLkGUcttXsvhsM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH 4.4 57/79] usb: renesas_usbhs: gadget: Do not discard queues in usb_ep_set_{halt,wedge}() Date: Wed, 16 Oct 2019 14:50:32 -0700 Message-Id: <20191016214819.867078789@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yoshihiro Shimoda commit 1aae1394294cb71c6aa0bc904a94a7f2f1e75936 upstream. The commit 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") had added a usbhsg_pipe_disable() calling into __usbhsg_ep_set_halt_wedge() accidentally. But, this driver should not call the usbhsg_pipe_disable() because the function discards all queues. So, this patch removes it. Fixes: 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") Cc: # v3.1+ Signed-off-by: Yoshihiro Shimoda Link: https://lore.kernel.org/r/1569924633-322-2-git-send-email-yoshihiro.shimoda.uh@renesas.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -732,8 +732,6 @@ static int __usbhsg_ep_set_halt_wedge(st struct device *dev = usbhsg_gpriv_to_dev(gpriv); unsigned long flags; - usbhsg_pipe_disable(uep); - dev_dbg(dev, "set halt %d (pipe %d)\n", halt, usbhs_pipe_number(pipe));