Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1041969ybp; Thu, 17 Oct 2019 07:15:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXvPmppaK8/vsJKyj+6+B2yPxXWKh5y1ks81JI9pt/pzOFmAX0nXGTqERFMYbVRUw77R4F X-Received: by 2002:a50:ed10:: with SMTP id j16mr3970522eds.227.1571321710540; Thu, 17 Oct 2019 07:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321710; cv=none; d=google.com; s=arc-20160816; b=OXsVLNAh2+KF651a5jlxbjgAsFnmvTHADGi6Sp8PoVd+5Olau5muTS5p9GCU1rARkY acS1LMQo949r0gz5IkooZJtlhC3vEIaXCo6g6XoTi/gCMblAe8iWWnw350l+K6UbKuKn KUJtMaNPIrhrj66taDCdjD0d/zEVy47ncPJdnYMcGRtIT2GGUWCfy/s/CVmJDs0x9+aH iH96ZsdNagOR+xOqX5hOF3Amdc2YKOaTtmyy04W4AJgT1bBvxAeYnyHas8rSZXS/ViVQ D2SR3NIi2gOIPS/1TvmAwIYE5Pgq5OSWNiX/BAiTYwFxe1lbs2n8rw9Le4lzOANLR9va sIKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PQzNb0ErqS7RJ0HdFT226maWPMid6vBkpHFw7N6A8Zo=; b=k4YNwkirh4NgWIBVQg9RJYU9BUSLvu6+oPDB29VsAwvHvnC1ZsNjJBMLMSTIipSb0c BMQbSgroVWMB9OiuoOY34IxLgRMoGWYtDnvTZYoNPuiMVmtFMCKxsaP7CMlTSaQti+Sk 7FuOQta+UMSZFPQtF9ec36gF0mLau8g4GxY7ud11iNyg9rPQ34ZGHEwlsZm5GgLAGFiT 7U03qA9aCZY0MHgbUi4JOZxQFV5akNu/Qwq0lWMO5Q8dxEIaAOAT7nbkvQUuZSNL96dA BqLEFH6Fe0aPktK6sjNXvL5Z7/UspSk15AGMlRL0V3n6+L2iWpAc36d1Wh0Z6ZB2VVZA QTJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lAl4zB3i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si1548617ejf.247.2019.10.17.07.14.47; Thu, 17 Oct 2019 07:15:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lAl4zB3i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394897AbfJPVxs (ORCPT + 99 others); Wed, 16 Oct 2019 17:53:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:42880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437575AbfJPVxo (ORCPT ); Wed, 16 Oct 2019 17:53:44 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCDDA20872; Wed, 16 Oct 2019 21:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262824; bh=GQe8EeLqG6PpoebDlvdKElf1ra2zPi7pDl6tBmXa50E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lAl4zB3iX7g08QTsvGt+6/Cx0gb5qmqHgzufW8tSM7PwpUHIfzkz4dV49WHnz54x1 5taDWxW/MuJqNi/E0jQo553QfmkklANerCgFQ6JTk5zsWIvnqlL0hvMaKMo2tQsQiy tj1oxgGYrrZR77UEIVvKsjqtrhk38OjBVXelVUEI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ian Rogers , Alexander Shishkin , Andi Kleen , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Wang Nan , Arnaldo Carvalho de Melo Subject: [PATCH 4.4 67/79] perf llvm: Dont access out-of-scope array Date: Wed, 16 Oct 2019 14:50:42 -0700 Message-Id: <20191016214826.803890383@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Rogers commit 7d4c85b7035eb2f9ab217ce649dcd1bfaf0cacd3 upstream. The 'test_dir' variable is assigned to the 'release' array which is out-of-scope 3 lines later. Extend the scope of the 'release' array so that an out-of-scope array isn't accessed. Bug detected by clang's address sanitizer. Fixes: 07bc5c699a3d ("perf tools: Make fetch_kernel_version() publicly available") Cc: stable@vger.kernel.org # v4.4+ Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Andi Kleen Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Wang Nan Link: http://lore.kernel.org/lkml/20190926220018.25402-1-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/llvm-utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/tools/perf/util/llvm-utils.c +++ b/tools/perf/util/llvm-utils.c @@ -214,14 +214,14 @@ static int detect_kbuild_dir(char **kbui const char *prefix_dir = ""; const char *suffix_dir = ""; + /* _UTSNAME_LENGTH is 65 */ + char release[128]; + char *autoconf_path; int err; if (!test_dir) { - /* _UTSNAME_LENGTH is 65 */ - char release[128]; - err = fetch_kernel_version(NULL, release, sizeof(release)); if (err)