Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1042072ybp; Thu, 17 Oct 2019 07:15:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxoEdxcyY5uu1P2xx05tX+ztpJEr1aUAEEvy0YzYPRVim21A7vvKFkXG9T454M5VaNub761 X-Received: by 2002:a17:906:1fc8:: with SMTP id e8mr3722631ejt.86.1571321714604; Thu, 17 Oct 2019 07:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321714; cv=none; d=google.com; s=arc-20160816; b=fj+gTS1oCqyxONiXxq2Yky3N/KllWkwBs41/Ni745K1krK1w0xpZFm0iLqeKoZ7bMQ M5JsAnAROk0u5eISODUZTD9tv0f4FB92tK0D6aG7ZNONkr5dEpeNRJ4JSd8eZjvEJL0M 8Xmtp9uLNQOQYEGiqzKSbBS1DIDXQlLiy1Q1Pj4RAfWonQc9kfqUsOlSF9ACcQaG5sKw I1X/FMz5bjtH9kL15/qjLw+5w/LGe/M095KQjxZaOmk88X9ywkC4NvIO87hi3RnHitlg QyVRGd67oMl2L1ZkqSRU5PqC17xLdTaqnEB4ovpVnOt5CqJn5tJgx+yjG7Wgfub89lJT QscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4dJchmAnC+6+uYQFOA4DXe3V74QkbK2qMN0RelPYUEg=; b=SfZvJ5QhY2hDviI2SCizRLYQuE+Wpx7Vq+dVWtSRERMCuM4+YiUlpxpPBH5Tr3Xt4j HcPosPykZDx9cjctl813EqygzSpr0bS2Wwz3w96UwuvqHkQ9KdD8SmeWB9dcY+KsmUYR 2CZSNWZXW/kYOBV5gMd1vEDkllTYGYxoCOFVFv4jm1+AZvJXziG+Z6JQaPvxpDH3CIVI 1THl7za/pHpbMQOZJrb/C7MAK9nAKsP8tBLhlcL/kGnr1YcEvXU8kY+HTsWoZBnPXgiY TU2t8gahYkGjx0q/pbR5iBrvqAgRjEHBNt86LNZhWgCea7qDkW6cFEby4wGbZq2TTe2T 8ruw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZIEZVDjh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8si1484669ejf.58.2019.10.17.07.14.51; Thu, 17 Oct 2019 07:15:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZIEZVDjh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437593AbfJPVxu (ORCPT + 99 others); Wed, 16 Oct 2019 17:53:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:42882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437581AbfJPVxp (ORCPT ); Wed, 16 Oct 2019 17:53:45 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3349218DE; Wed, 16 Oct 2019 21:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262824; bh=ae6/NC+XVZ6N9jv7fZixkPTzSBcQobnPHkR/ANXDiaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZIEZVDjh4Jjn1We34EXD0cn5lUi20hxB6OX/Huv2igxe03xsEYoBy4etyqAsLSvDf cser8oPDkrR5FSdDT+weznacN7+Yh57LTdlHmPm4QtlVjXHeBtllzo8CJtaYYZqieV eTiKPCZdkdTA6xqF8OgxTyYdpP9J25+LeD/EKF6I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 41/79] USB: adutux: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:16 -0700 Message-Id: <20191016214803.880671748@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 123a0f125fa3d2104043697baa62899d9e549272 upstream. The driver was accessing its struct usb_device in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: 66d4bc30d128 ("USB: adutux: remove custom debug macro") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c @@ -152,6 +152,7 @@ static void adu_delete(struct adu_device kfree(dev->read_buffer_secondary); kfree(dev->interrupt_in_buffer); kfree(dev->interrupt_out_buffer); + usb_put_dev(dev->udev); kfree(dev); } @@ -681,7 +682,7 @@ static int adu_probe(struct usb_interfac mutex_init(&dev->mtx); spin_lock_init(&dev->buflock); - dev->udev = udev; + dev->udev = usb_get_dev(udev); init_waitqueue_head(&dev->read_wait); init_waitqueue_head(&dev->write_wait);