Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1044110ybp; Thu, 17 Oct 2019 07:16:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzloEwpBq9thjfJtuGz2E/q95iUskm01Y1fxIVOyztRXoFwcV7crcnSpkQq8lGUz4qaNXDT X-Received: by 2002:a50:ed01:: with SMTP id j1mr4032875eds.111.1571321811939; Thu, 17 Oct 2019 07:16:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321811; cv=none; d=google.com; s=arc-20160816; b=O5P17JGsdcp+kc0mPwTDNjqPjDYyAoTtByuv68ztQqvRxvF9lvOPgn20fS6kiv1L9y vAHS6eI67ql6740AvLif6xREnom9vc2pMaSSJsfxPzATBwQyerX+jFP28MX6cHZYTuXZ BKJlkxVMFk5uqyqTOP30qFVQEQnJ2d7dr7T9InUF2f+wjsF+ETZLv+wDFo3o0OTMVGUr yglZGiCnLZ6XY8dlVm8z2FngIGWO/kOaY2euQ6401uT4lVigQmskgdJZ7rK7+NmuNaE3 oEFVg0Qh8eNPac8j92on4N+NwUPcf+KK5yK1rqV9nbXI6Jbe0nsp0fzQDRipMpHyGzxk ba8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=j0wcJ1ftGqTnS79akxzNCUFbrd8qOH0x1+32o/pwrh4=; b=hZXytlZluqO/pS3VbNWGm58o2RYzwfarf14FECMzENgJEgPGfcVXqp01nTC/+z1UAZ 1/IIcTXVpUmy4eBaQTV3HnHC5QUmflewk9DLWXdOf4DpAn6pEDsHiBtN0/M/PT1+DggY ZPqEwaUAQiO6Ublp4He0R/lCPcjw1EBQWX/GHloe3SVq1zEwn/2/slFtTZx1QAJCI4Si 1o1wpLtv+beZbylH97AsePj63xs7elhFK6yLB1dH1OTWAWCZaN2+Of2G7XqlBs9RpxN9 AhMQ7Xm8ZVxJ/hMhV8irwgqNnyK+mUs433CBRPHEtbDY0NrHw4AMAagVYQMfNUucxZjT fesw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YXyRYnPD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c51si1569347edc.317.2019.10.17.07.16.28; Thu, 17 Oct 2019 07:16:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YXyRYnPD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437668AbfJPVyF (ORCPT + 99 others); Wed, 16 Oct 2019 17:54:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:43400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394933AbfJPVx6 (ORCPT ); Wed, 16 Oct 2019 17:53:58 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08FD721D7A; Wed, 16 Oct 2019 21:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262838; bh=QsOC5gohWhKu68x3DEK4fIwmbT7ZiSvW2vWkbWuQVeo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YXyRYnPDDwFrc5Wd4h/IPxkrTO0t20uVyx/qVFpdfqa47SomfxYBWCCWkMSViXeur UsQ2ZpAxkGpp4jIEbEnYZuV9BvnOF3UTeusnoLzRzBBFUj1s5QskjhAuiYNmp+fp0U gFS3NltEYOFATOHegwnZYRtAxL24a2UkTVIYS6lY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 43/79] USB: iowarrior: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:18 -0700 Message-Id: <20191016214805.448643299@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 80cd5479b525093a56ef768553045741af61b250 upstream. The driver was accessing its struct usb_interface from its release() callback without holding a reference. This would lead to a use-after-free whenever debugging was enabled and the device was disconnected while its character device was open. Fixes: 549e83500b80 ("USB: iowarrior: Convert local dbg macro to dev_dbg") Cc: stable # 3.16 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009104846.5925-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/iowarrior.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -248,6 +248,7 @@ static inline void iowarrior_delete(stru kfree(dev->int_in_buffer); usb_free_urb(dev->int_in_urb); kfree(dev->read_queue); + usb_put_intf(dev->interface); kfree(dev); } @@ -782,7 +783,7 @@ static int iowarrior_probe(struct usb_in init_waitqueue_head(&dev->write_wait); dev->udev = udev; - dev->interface = interface; + dev->interface = usb_get_intf(interface); iface_desc = interface->cur_altsetting; dev->product_id = le16_to_cpu(udev->descriptor.idProduct);