Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1047835ybp; Thu, 17 Oct 2019 07:19:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGyR6d3thqYPbxuGB1NVudc+OFu5o9hH4euYHto1bQRJzY4bDNwTOx8iFFOwkLhbgDnCKT X-Received: by 2002:a17:906:418:: with SMTP id d24mr3730599eja.305.1571321984649; Thu, 17 Oct 2019 07:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571321984; cv=none; d=google.com; s=arc-20160816; b=0hZcZTdMHcy21NpOMXLCuT9scrotqzk8jcxM3oieJqLlqgvbzYDlabeWc+PKhYJRzQ ELwdcBH+iewbxYccT+BPJi2FgYQmxA5fJJd+fd91ucn+5/g66r6RI2w7UUwANn+Y58uB J5rr7m+VYtCq2tC0cAVMxtDvOY8FWlNejhbmq/qWcDtgWcvIWtdt4Dt9yA1OMPwKQ0Q2 49fwtoS4xj2/9EQ8l19OGgSRTRGbYYm0q6ftSEWVwYtI9c7Tw/ajsAfb4sN+SA0GTrcK /NvLkuiSNI/eIj9cj4RCobmYwBAHp4y6rnQBNLle6O2n2xb89zH5A8z59a4BLcw4Lm/m 0tGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zRkzwpteccl7UyOSSiJKp6Bn4479EUbgXA73JPlf780=; b=Iz9tliH5p4GtOvub67K4zjzz4PY9k7Brg4oeX/tz+wSvDhK06w/ARw3PbzpE+9O2ew Q98RUGd5bj5N6IqOw0XuTgnHGLGEm+Yw+cN04dfSbtW9CJ0aBLclYdgz68T1cjYqbewL CKgIo0r54Ql2+qbYb4d8V81MQVTsi+hdiBlee1sjqAQLXYgA5LUiw/4GLUGZ1k1EvP1Z mkEfPlBTvBDBVyTvN3A1nVXGzyC+XfMMrCzN+j/yyuRq72IJhAyLprTy4Eq9zhrrAKUT wf+xBmefJGXOCKZ9pIytMLyssxOETylcrdn3mqUk3ZqVfbl2b6DpIPtyzqwTrSyiI0W9 50pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iThn3MpL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si1649360edc.224.2019.10.17.07.19.21; Thu, 17 Oct 2019 07:19:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iThn3MpL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437708AbfJPVyg (ORCPT + 99 others); Wed, 16 Oct 2019 17:54:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:44118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437703AbfJPVyT (ORCPT ); Wed, 16 Oct 2019 17:54:19 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1968222C9; Wed, 16 Oct 2019 21:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262859; bh=8osOiuLEA4bTqyQk3oWduH2334I6xYBmy+/krY4WAf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iThn3MpLeP8J8OQNbwX4dJ+gX0kiE96rNIeuiJMsRWzN75Sd8XJt27Vy6A6ANyDiL pMD9iEL6WSpyWC3zbrAyV0MTNU+cjx5hquFLZ3ooxXZY+C7BWW7kbsN5K0ozmmbHfm BDqB/BBEkHcqD06rngx+RybwPr8PtB1P6l0KCwf0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Ellerman , Andrew Donnellan Subject: [PATCH 4.9 07/92] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Date: Wed, 16 Oct 2019 14:49:40 -0700 Message-Id: <20191016214804.493683777@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Donnellan commit e7de4f7b64c23e503a8c42af98d56f2a7462bd6d upstream. Currently the OPAL symbol map is globally readable, which seems bad as it contains physical addresses. Restrict it to root. Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") Cc: stable@vger.kernel.org # v3.19+ Suggested-by: Michael Ellerman Signed-off-by: Andrew Donnellan Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20190503075253.22798-1-ajd@linux.ibm.com Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/powernv/opal.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -579,7 +579,10 @@ static ssize_t symbol_map_read(struct fi bin_attr->size); } -static BIN_ATTR_RO(symbol_map, 0); +static struct bin_attribute symbol_map_attr = { + .attr = {.name = "symbol_map", .mode = 0400}, + .read = symbol_map_read +}; static void opal_export_symmap(void) { @@ -596,10 +599,10 @@ static void opal_export_symmap(void) return; /* Setup attributes */ - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0])); - bin_attr_symbol_map.size = be64_to_cpu(syms[1]); + symbol_map_attr.private = __va(be64_to_cpu(syms[0])); + symbol_map_attr.size = be64_to_cpu(syms[1]); - rc = sysfs_create_bin_file(opal_kobj, &bin_attr_symbol_map); + rc = sysfs_create_bin_file(opal_kobj, &symbol_map_attr); if (rc) pr_warn("Error %d creating OPAL symbols file\n", rc); }