Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1049286ybp; Thu, 17 Oct 2019 07:20:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVID1xUHd7aNzhyIqFDU/2LC0MF4wQtzq4ToRzY8n7jt8VgVMzMsaZZ1pnTs2U5ZV01sdT X-Received: by 2002:a17:907:39b:: with SMTP id ss27mr3606677ejb.151.1571322049549; Thu, 17 Oct 2019 07:20:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322049; cv=none; d=google.com; s=arc-20160816; b=MDL71MjIKbw8WzCFesFR18DxR/juIouLbtxmLLoHJ93e9jc+7hsOpLIWzgbNYFYE71 KsIo/1W4xRbVvEreNiWFpWbvfTWg3oHuTSHht2edqtPJpaE81A4jP3LqFwrgCfT1gUI8 f/ViN+TctJauD86MY6XjL8rAvhKpvP2cD031RP+ASw/eDw2l2XoG6LDl3eD89N0SG1H+ j2bCPk/5s2Yj/TByJSPhSLmcBUn9jgpHXVSfw32QaDTVNf2ZKNZ+y9NGx06JQjzalcVl fLEkcDDBtNyI7fQ2MNpx1dZbwLwgX5j+LPUJKYV3V2OEbwGMwAfNkwIZotx4/SERdTA7 fcxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ds6ZXXyrQzfR35f8jwWn8oBm0mAyBiU91YoIxBxjyyI=; b=RgmoiKOgtTDJ6XnA0axCwrJhVD7F/3Pd5or6v5vTB+2uNCijNVqBar1QddNSojhew1 0BIcJHMM42A5wX5dnHyRoQ2+ArDXBKf4OxWGYuDNKC6SzdTeNPnfrZRZBpy9RXDqYP1N 41DOln5Fsph2SvEdR8a4ixLaVCGjUvEwMn87DSDPlPjul5D6or1KoguOUO1wtJDdbF8R F+/tnEUJima+jej5ZU7LWpyLTqR/RXzTxcfF+450kJDKPatb+boqAG4Mi9FneTlo/4JU CJX1dXzexGpD/KSxHiWX9EWRHZy+lOF8rU3mwxLPT8eUkyeJo7qIA/Zlx6Zd58rLSOCK 7mpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b50RGf7/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z10si1390510ejp.397.2019.10.17.07.20.25; Thu, 17 Oct 2019 07:20:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b50RGf7/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395061AbfJPVyp (ORCPT + 99 others); Wed, 16 Oct 2019 17:54:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395016AbfJPVyd (ORCPT ); Wed, 16 Oct 2019 17:54:33 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84F7320872; Wed, 16 Oct 2019 21:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262872; bh=XcoT/50f9fWF2zLsvDahJadR7e2rbv6TMDZt5+85trw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b50RGf7/FBrlupqKn3osH6Qf2bA4pwq+G0s3sDmrHFFqkXXbzU4Q8DjyEmwMFwOIw FF0XzRJU1LwDantR8BucOvvKmLkumUgfuLdiSmCVx2y9CBwfLFsCGBwy/upiIBi1Nf Y6wFb0BeToCbGETv4fiei/4za/NfLaz/v1LpSstc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Will Deacon , Xogium , Kees Cook , Russell King , Ingo Molnar , Petr Mladek , Feng Tang , Andrew Morton , Linus Torvalds Subject: [PATCH 4.9 36/92] panic: ensure preemption is disabled during panic() Date: Wed, 16 Oct 2019 14:50:09 -0700 Message-Id: <20191016214828.213152289@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon commit 20bb759a66be52cf4a9ddd17fddaf509e11490cd upstream. Calling 'panic()' on a kernel with CONFIG_PREEMPT=y can leave the calling CPU in an infinite loop, but with interrupts and preemption enabled. From this state, userspace can continue to be scheduled, despite the system being "dead" as far as the kernel is concerned. This is easily reproducible on arm64 when booting with "nosmp" on the command line; a couple of shell scripts print out a periodic "Ping" message whilst another triggers a crash by writing to /proc/sysrq-trigger: | sysrq: Trigger a crash | Kernel panic - not syncing: sysrq triggered crash | CPU: 0 PID: 1 Comm: init Not tainted 5.2.15 #1 | Hardware name: linux,dummy-virt (DT) | Call trace: | dump_backtrace+0x0/0x148 | show_stack+0x14/0x20 | dump_stack+0xa0/0xc4 | panic+0x140/0x32c | sysrq_handle_reboot+0x0/0x20 | __handle_sysrq+0x124/0x190 | write_sysrq_trigger+0x64/0x88 | proc_reg_write+0x60/0xa8 | __vfs_write+0x18/0x40 | vfs_write+0xa4/0x1b8 | ksys_write+0x64/0xf0 | __arm64_sys_write+0x14/0x20 | el0_svc_common.constprop.0+0xb0/0x168 | el0_svc_handler+0x28/0x78 | el0_svc+0x8/0xc | Kernel Offset: disabled | CPU features: 0x0002,24002004 | Memory Limit: none | ---[ end Kernel panic - not syncing: sysrq triggered crash ]--- | Ping 2! | Ping 1! | Ping 1! | Ping 2! The issue can also be triggered on x86 kernels if CONFIG_SMP=n, otherwise local interrupts are disabled in 'smp_send_stop()'. Disable preemption in 'panic()' before re-enabling interrupts. Link: http://lkml.kernel.org/r/20191002123538.22609-1-will@kernel.org Link: https://lore.kernel.org/r/BX1W47JXPMR8.58IYW53H6M5N@dragonstone Signed-off-by: Will Deacon Reported-by: Xogium Reviewed-by: Kees Cook Cc: Russell King Cc: Greg Kroah-Hartman Cc: Ingo Molnar Cc: Petr Mladek Cc: Feng Tang Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- kernel/panic.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/panic.c +++ b/kernel/panic.c @@ -144,6 +144,7 @@ void panic(const char *fmt, ...) * after setting panic_cpu) from invoking panic() again. */ local_irq_disable(); + preempt_disable_notrace(); /* * It's possible to come here directly from a panic-assertion and