Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1049701ybp; Thu, 17 Oct 2019 07:21:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxN1X4+jrhHOaw+XwOoFzU3rWoOgaZr6lcYfZN3yEnKWx09vELfTGDGJVCokaPGa1hDtT81 X-Received: by 2002:a17:906:6094:: with SMTP id t20mr3742098ejj.316.1571322068768; Thu, 17 Oct 2019 07:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322068; cv=none; d=google.com; s=arc-20160816; b=a0gbROyjMM4Jgxt77iFv67gl3c9bfVnJfEGnowagLjB+l0b8wIF0/1qyixyz2NwxDQ +YX2YRwxRHgMZVP6PXgiZMrL4mX7FKz8446nj6r1IcYs8SfBzxi+YFQXBrBI3azHOQe+ 2VlWtL9uvUkHAr0HmqW1d+mg6Ob2b7GM255UI8vJTFE95dg6dpkBWUV5VgJJfMUA07eB T5MqZkbOuUc255hqkpurt8WXt+STIQzMeXSc+OOmq+W9JvIp4bZ4/zAvQ9G0/WeYwkiZ CpxmxkczFlNFyvGZk9R/3E0ga1bH+by58jxH0EEwHR+Vc8jRLTRtn3y5wZ9DgquTdweb gh/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rZQWWyDoS7L5jWaGrZmtEYVkK9JQTVtqjC28ma13exk=; b=RSoXFnB+J5bLMfme2rFaUdfJWFQd+DMFzqTs3uMp5Ex9ZfwBxGtxdBKRiRlM0osfbl /vD9XSSHusHL0YvY04tCwoXNZkL7TxLDBLH9OSDY9sQJkGlJNKLB9vpW3f0qhZ8NOPxM NeXCO5XoUGPxbN71QCVGNfLVyFTaQjlcMSpKvOfo1vAPBbQDrHLXq4beZ7z92z9KWs7l N3iLnH0meO1WZHtirH+x0GoMvsHS22a1bo1h6ynflOBXtBxNc56YnO8E0TD6wdGzbGeL 5pe6Dpu3SOUIaOVuSIqrS5pX84+All3fxsWSjyaXvm70qmvR1xznvhWMd4QZxWaHYnAM 4ZdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ja7Amr/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si1758895ede.380.2019.10.17.07.20.46; Thu, 17 Oct 2019 07:21:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ja7Amr/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395119AbfJPVy5 (ORCPT + 99 others); Wed, 16 Oct 2019 17:54:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:45006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395079AbfJPVyw (ORCPT ); Wed, 16 Oct 2019 17:54:52 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D61521D7F; Wed, 16 Oct 2019 21:54:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262891; bh=V4BRBRezsqDW9FCesNNYVtuI0Ud45BnOrAw/VPLoSY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ja7Amr/7LkN3iMKT417ZxXXPTkjhwemGspLjR/fRWfuQKtRjnZNPJvlMNtiMzACBM 07qbeFRypO6cjG9Av89jp3weeaPG2/FhvzKvG0wfDLObRV1sLjYtIiJ4jYnjng4tD8 BgvI/jNmgmw3pfWbafgdVK18NYCl9q/jh1x+2hdE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+0243cb250a51eeefb8cc@syzkaller.appspotmail.com, Johan Hovold Subject: [PATCH 4.9 48/92] USB: adutux: fix use-after-free on disconnect Date: Wed, 16 Oct 2019 14:50:21 -0700 Message-Id: <20191016214835.001785907@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 44efc269db7929f6275a1fa927ef082e533ecde0 upstream. The driver was clearing its struct usb_device pointer, which it used as an inverted disconnected flag, before deregistering the character device and without serialising against racing release(). This could lead to a use-after-free if a racing release() callback observes the cleared pointer and frees the driver data before disconnect() is finished with it. This could also lead to NULL-pointer dereferences in a racing open(). Fixes: f08812d5eb8f ("USB: FIx locks and urb->status in adutux (updated)") Cc: stable # 2.6.24 Reported-by: syzbot+0243cb250a51eeefb8cc@syzkaller.appspotmail.com Tested-by: syzbot+0243cb250a51eeefb8cc@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20190925092913.8608-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c @@ -792,14 +792,15 @@ static void adu_disconnect(struct usb_in dev = usb_get_intfdata(interface); - mutex_lock(&dev->mtx); /* not interruptible */ - dev->udev = NULL; /* poison */ usb_deregister_dev(interface, &adu_class); - mutex_unlock(&dev->mtx); mutex_lock(&adutux_mutex); usb_set_intfdata(interface, NULL); + mutex_lock(&dev->mtx); /* not interruptible */ + dev->udev = NULL; /* poison */ + mutex_unlock(&dev->mtx); + /* if the device is not opened, then we clean up right now */ if (!dev->open_count) adu_delete(dev);