Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1050876ybp; Thu, 17 Oct 2019 07:22:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhKCI9D+E2VMTQCKCnuqfPAl72hGzB8BWdHHuevP5lHkdSBeg+elWcV23gXd8KPGgaJhLb X-Received: by 2002:a17:906:3c4:: with SMTP id c4mr3763077eja.302.1571322125664; Thu, 17 Oct 2019 07:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322125; cv=none; d=google.com; s=arc-20160816; b=wRc13SptK4OvdiVSbVPwdIc7rTNUrVZeUFWj34hDD8Q0SzeRaSfVK3i3OYKMlAxYmR iwy2Anr0rURNqILheR2FbOXfQBVhZhkoSPq6jDGT0F0ncL5pKMcnU2z2L8G2n1ucss3+ C2gOZJAc1jBUv/SjOBQY7ay7P7tFoC70UCILLH9aLODLMLqAiVwpPkc9JtW+tpeVLYcF ExaJSsNxoF93RBGoZQzBII68dPPW8bBw/EDrwCicANuVA0F+r76KJEQ5neh4npoxMojZ /oB0dC1M7hSd0tuiB1oVxOcI9SCgZAC648yJWxgoKD4hHfk4wIID2MNVpZy7esxiiq41 DhOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P4B5Xbsay4nZFjeBDYbkeGO3G8HJnfou42v1m4qXNBM=; b=PNCU50UlwhJTPZfBjI/Nn3E3lqGDotYNmcPrw91fRm1rc7E8nSM5k00r4cg2iO2vIs r4qRP+gTdWd/HJYZRNd8e1c7VjNTcsUo2nUVkl6vJ9idhHTyBp+SNQXGxOM7t9gv+Uk0 DvXpajooRlu/4NgS5jEHK9jhTwKHrWIYWCsIkIPbhF56AOzCHfalFDLp0xr0F0J8jo06 zte2DbwnrErNXeIG12oIHxrRNQuydGxlt5a6ghscUtdTvicSQAcaepu28A/T1i3S4F8p D/AcZiw7waSzVLzLjxWwAGXxBHhqS5DIuvw6IeFLiiMs+BBmra09NbWAHZJnAxTe14E8 FyUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x0gFMXg9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si1621118edw.29.2019.10.17.07.21.43; Thu, 17 Oct 2019 07:22:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x0gFMXg9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395198AbfJPVzK (ORCPT + 99 others); Wed, 16 Oct 2019 17:55:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:45316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395158AbfJPVzC (ORCPT ); Wed, 16 Oct 2019 17:55:02 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06F5321925; Wed, 16 Oct 2019 21:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262902; bh=0BzHUrQye+rYcXuCHNc0Yjq0lAfviyokIpifD0QV5O0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x0gFMXg9Fdcj13iuMt8Y86AWdQTxpR9xpbW5SY2FgJiMVxLZoNbKYjoU+iXwGXR+6 mHblPGCaZFDcmsi9NC3LLRLv8nGWAHl7VgbSCAKcvns2etC7CkTmImyY4KNz1QGT7O AYTAmossPqpca8sOELFuXxm6KQs83tCBW+G3dJ9I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 62/92] USB: serial: fix runtime PM after driver unbind Date: Wed, 16 Oct 2019 14:50:35 -0700 Message-Id: <20191016214840.649571424@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit d51bdb93ca7e71d7fb30a572c7b47ed0194bf3fe upstream. Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface. Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device. Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191001084908.2003-4-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/usb-serial.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -315,10 +315,7 @@ static void serial_cleanup(struct tty_st serial = port->serial; owner = serial->type->driver.owner; - mutex_lock(&serial->disc_mutex); - if (!serial->disconnected) - usb_autopm_put_interface(serial->interface); - mutex_unlock(&serial->disc_mutex); + usb_autopm_put_interface(serial->interface); usb_serial_put(serial); module_put(owner);