Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1050973ybp; Thu, 17 Oct 2019 07:22:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSArnNUBYhprzugY0ls8JiJkJVtk1RXxZaSi26EKRA1TOPvVUcfIhZ4yIsuS5soxGnS0FB X-Received: by 2002:a17:906:48c6:: with SMTP id d6mr3714763ejt.291.1571322129957; Thu, 17 Oct 2019 07:22:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322129; cv=none; d=google.com; s=arc-20160816; b=zHPQOYlUcblC2jJLGURCLah14HFMDLoleukAxZ44iIF/0K4SmTYJTO1cvIzYjJtiw9 66sD1biXIRkcFGUMy55UbC0/TUPrDhu7UFWilRnldFiBmGS5v5ivT8tHwmr9l9n/P7h4 HN2/vB4CoUPu3UGJ1DgQFHutIdVehWsR4T5uzclq1d8W/hkN09lAGN2BSUpz5Y5vvp6V z0PWPOcGP7fDxbGR03sp4i/Iuzaw1p+npOjhzEY5Vxbp/vtUmCBH31Ry/vfR95bwWA9/ BXAE+rgcjOnNcKv53Tc4bAcKX7a8QIpdLAI9Ah6eQ0UolR3XU0tMpT0RwCB7n9rIEtsF R7gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8nh8NVDQIj2LXS0De9hSbJ9HW97BAJRHK3R3l8AHNTo=; b=thIQnOegUNiH+d8mnRQuwe5Yvk1+tG9UjQbe2XvEyYk3m5qFd46rMomql0YdAia46U fZu1e00CwW/EWDQX0i+amegQhKAivuQfnVSmvITnut9ZhCJkr1UHcDJv6J40/s1gf8B3 kw5qOeIQ3mW3httg6PjWkCaz1x2+tX/CNejAQJ3+3WLxc3RaL1SnPUDKgicK6hNwWwVX V/GO7LeESNzDjyNV+QsSOTc6P9qtwIRojZ5YhhaYFwyWSEwyxClnXrUBT9Ba1OUJCsbS zlFAPvhuN2xZNxR7X8UQnmWDg7gk25cDp6GKPbQzGMdipNPaVs73BRs8rp5o9aQqMUU8 F12Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=beGJNmcH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si1356126ejp.287.2019.10.17.07.21.47; Thu, 17 Oct 2019 07:22:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=beGJNmcH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437715AbfJPVzM (ORCPT + 99 others); Wed, 16 Oct 2019 17:55:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:45446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395180AbfJPVzG (ORCPT ); Wed, 16 Oct 2019 17:55:06 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 988DB21D7F; Wed, 16 Oct 2019 21:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262905; bh=1+1fyWTqgaYeBWPbe4DGTlwrzehJQTZxrXvSRxP2qjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=beGJNmcH5pT7nae0XVIWpU64OHrLer3TfKmpG0lmrkyF2/tT43FlaMEC9wHnAr9eF 9yCUqHRosQ2lbfJmE9Tfm5rHC2720d6Gy+eYAYl91MMeelzV4S7ugxE4nd1/CPwGk9 040Vgn9n0ja1XMpl36EneAHaKCVFMbZX5/UurPWA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH 4.9 66/92] usb: renesas_usbhs: gadget: Do not discard queues in usb_ep_set_{halt,wedge}() Date: Wed, 16 Oct 2019 14:50:39 -0700 Message-Id: <20191016214842.396485132@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yoshihiro Shimoda commit 1aae1394294cb71c6aa0bc904a94a7f2f1e75936 upstream. The commit 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") had added a usbhsg_pipe_disable() calling into __usbhsg_ep_set_halt_wedge() accidentally. But, this driver should not call the usbhsg_pipe_disable() because the function discards all queues. So, this patch removes it. Fixes: 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") Cc: # v3.1+ Signed-off-by: Yoshihiro Shimoda Link: https://lore.kernel.org/r/1569924633-322-2-git-send-email-yoshihiro.shimoda.uh@renesas.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -730,8 +730,6 @@ static int __usbhsg_ep_set_halt_wedge(st struct device *dev = usbhsg_gpriv_to_dev(gpriv); unsigned long flags; - usbhsg_pipe_disable(uep); - dev_dbg(dev, "set halt %d (pipe %d)\n", halt, usbhs_pipe_number(pipe));