Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1051196ybp; Thu, 17 Oct 2019 07:22:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzEDbtk1tRwPPsbF6JEnb9JRRLTw45JAeSM8JlFAy4WLQRVjFLIi2AM1jJHtnONK6pROVzX X-Received: by 2002:a50:c949:: with SMTP id p9mr4006590edh.25.1571322139536; Thu, 17 Oct 2019 07:22:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322139; cv=none; d=google.com; s=arc-20160816; b=Uh5bdHd2nwYIpsPDKLzNw4u6jsQidrq0XJ2Z2Bw3+YZxPEx/pkMA7Wc64ILUOQZZqX sgh2l8onykBWgGTcKy3FHBFOOlYLQykwIin+HyUjXPM2LD+Mhd7yPSYcnVwvVp+yo1pj SFzteHjNGQpjpkcaPJiU0Rq6/zg56+RsdMdo1Xg+AgqzdKaf+5VwveZfXkK5S0JvNTHu /NqjynVaV4yWPYziVpttSITQUmX0t4TGUrwD/cA4ot1VMK1m9GP7WOwJoHw0P9bz3hiH /845V2tKhGIwCY+zAyT9KJvASQ2GUnUEb+6o69SuHUFP9kG8MGX1CHGtU0qi6wf1uXuk aiXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rbM/VEs73MoULotEqHZ2uM4j4EmC7rKqga9xvh9cb9s=; b=YQW6FE9FEH0RFhVUN52iN2ozqACfi/IPq1JMHM2TssD/jpLDkE2I+YQQX7zvwoMRci Mta5y/3TFa53fXPVro1BoJ+HAn3/XZpqrqWbOgXO2EE2DQtZdb1gwqVp9l6nK9vMuMLP qLKQktjmvMFh8cyd+zE4cFVVh9TYklDkOsNSMeM6imsCh6H61M93685nlmdqm1205kA6 EM3F+HVALxPViRTrEvFtaI6S8RdBnHplutjoqq4o1dxNp9O9JPRDPdvr9dbss8EZcjG1 Wp8i0d/3Ef9Q+y9oPyDcQHkZsoEv9FRSj0ONjVUM0o89ixH32NCBuFc1E87HdTucOF0H UEVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rr3ZGp//"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si1461460ejr.246.2019.10.17.07.21.57; Thu, 17 Oct 2019 07:22:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rr3ZGp//"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437760AbfJPVzS (ORCPT + 99 others); Wed, 16 Oct 2019 17:55:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:45674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437725AbfJPVzO (ORCPT ); Wed, 16 Oct 2019 17:55:14 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67886218DE; Wed, 16 Oct 2019 21:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262913; bh=NULAnT487JWKocdUOvjYzvpKGwvjPMSpNvN1O/uwKF0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rr3ZGp//Gks0jjhCA4Alu4p9cbz4J6dW5qbDwHOQosNZ5GXOGaowDjeAhN+h4QijK BIZOa2lksJrtzalJ7io5vhxUBkLa8+10s7PjVz2zuY/ewhfUxiuD5dUwkukbH/bSgo pziF+8Lj1JEacUq+Z8dZpvkxfLb3aDShwEZgZRBA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost Subject: [PATCH 4.9 73/92] staging: vt6655: Fix memory leak in vt6655_probe Date: Wed, 16 Oct 2019 14:50:46 -0700 Message-Id: <20191016214845.006129966@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit 80b15db5e1e9c3300de299b2d43d1aafb593e6ac upstream. In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost Cc: stable Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/device_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1673,8 +1673,10 @@ vt6655_probe(struct pci_dev *pcid, const priv->hw->max_signal = 100; - if (vnt_init(priv)) + if (vnt_init(priv)) { + device_free_info(priv); return -ENODEV; + } device_print_info(priv); pci_set_drvdata(pcid, priv);