Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1051784ybp; Thu, 17 Oct 2019 07:22:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAU7lbMKGydNLlatKN8bVj11TliI0yYThW4t5enNDic4/8tRZ17QqCODrDixYPSr2B3kc6 X-Received: by 2002:aa7:d915:: with SMTP id a21mr4128546edr.46.1571322167939; Thu, 17 Oct 2019 07:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322167; cv=none; d=google.com; s=arc-20160816; b=OkWMx2ewgYPyhuzb0sRju17GX9b6Ao4UoCMEWX+mOSxWvqDW5m1vpdTVQZtXINZb+8 z0nsxrsUeuSF+BnC9mou7Khtv5+mK4bbGgpj5Pg1znjI9RDeqUwWXVb9qzcu1KPeiRyr heuowkJngJIBTWQZR36+cf4b68QYOOEpyQbUL6/CE8Ux2emreeGfab4UoH6oilA9cAuc EKtg2lr8+48Qglgg3A/4nh9dbcsREZZQFUNPYXqT5++M21ItB0vhJwVExvV+Ht8rtsXX 9coBjUm++UV0+IC4BeR4RYDg1QKQZnFI9e11rvRvEwO4drmvOdJMhIFpxn3gj9nHWcWa XiEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=s77Ca+kMZ+Iv8mByKilEPjxviWhCokQFmLtCzMugLS0=; b=WdGoCDt8gyKyicnkRu+UnvBc39JPM1i1ELCctI91JRaiAWvakZhCIOdp/MH10lXgj2 V+QZkSOCsDyPTDfNL/GDyHvl/NHo+ZKdd21ppcEhFefFZ4DGq1SsNLD5Ey3EurA3Gwjd gTmcQHUB0rK0IGvQl3RLmTWIXTEgh4aAhvqBB5y7L7GE0n2HulBfCY5u9VOHQAuVrliB gzeU6rI6OgjssvbzBybcE5MazCoqdIJSzNZe3rWp6Zq7MhXMT7yPEtHxdN+GlsPxGYus HIbmssaOEyA2UzU5s8VDmwDr0mnnb7oUmW9SJDQHvwRZhcz8fXWchHAqcLcK2jUTJW9X CsNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H3vNjB5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t18si1434763ejr.416.2019.10.17.07.22.24; Thu, 17 Oct 2019 07:22:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H3vNjB5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395243AbfJPVzb (ORCPT + 99 others); Wed, 16 Oct 2019 17:55:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:46140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395213AbfJPVz2 (ORCPT ); Wed, 16 Oct 2019 17:55:28 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35F4021D80; Wed, 16 Oct 2019 21:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262927; bh=jpHkQuztPx20siRx6Ewm3JAV1X733A187RHAZxIdgMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H3vNjB5zn9ffZNgmmGORTVJ6nRlguQxWRHMPlsMXwZ0mfs/ow7iUOnaGyXvPnFtDr tYrcoBcJxIH4F4kixUTLOMp65/YUIDr9HrZahwfSjsFgXLLtXdyDGvZqgjeSAaD/3h Rp9nDMeOTtWXxh5I/iUd9I+5zV0rl5Xv84tKfYCI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab , Johan Hovold Subject: [PATCH 4.9 87/92] media: stkwebcam: fix runtime PM after driver unbind Date: Wed, 16 Oct 2019 14:51:00 -0700 Message-Id: <20191016214848.243121859@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 30045f2174aab7fb4db7a9cf902d0aa6c75856a7 upstream. Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface. Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device. Note that runtime PM has never actually been enabled for this driver since the support_autosuspend flag in its usb_driver struct is not set. Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") Cc: stable Acked-by: Mauro Carvalho Chehab Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191001084908.2003-5-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/stkwebcam/stk-webcam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/media/usb/stkwebcam/stk-webcam.c +++ b/drivers/media/usb/stkwebcam/stk-webcam.c @@ -647,8 +647,7 @@ static int v4l_stk_release(struct file * dev->owner = NULL; } - if (is_present(dev)) - usb_autopm_put_interface(dev->interface); + usb_autopm_put_interface(dev->interface); mutex_unlock(&dev->lock); return v4l2_fh_release(fp); }