Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1051825ybp; Thu, 17 Oct 2019 07:22:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwnLTevG0oq1KLTzFwERkxKdhyhXTf9XHgbDX302XjLUK9Wq/HafXK4407NKnzksibNtk64 X-Received: by 2002:a50:f395:: with SMTP id g21mr3963539edm.223.1571322169838; Thu, 17 Oct 2019 07:22:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571322169; cv=none; d=google.com; s=arc-20160816; b=ikdvyPZwLIHd5SSAPN4BWB8dHr5VQIi3LL/i1t3z/qeghhB5vyvVIZKfaOhzXUNKfG VU3DcJ3azend/URqoKGw35nA+5EVF6mk7tGdxxi87YzPGEdJKtTJW0ZO0Cd8IrDeBLj3 nmvLaDpNJUQMaW7S6fhEpaPsh+XCE2Nn+kIAPd0HUzfApWHB0S3UHM9hjagMVilwJhaL LrDQrlSBjQ9PawHsPM1B0dMM30ak7Mv/PJs54RiE0o9nJ9Bx3hhMCoy3ozO6OeZNQRog F4CyiQoUeKDGv5c6eu9QG5VfDP/3HPGW2XZwoOBEu6V7Vxn4Om3S723daD7mvo/VtdIV N/Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=r6yL7O0iHvBnrrYTc41BbWpg8T74mm7ZOAy4ImY4GbA=; b=mxv5tkSKMbMeTcHA4Mm2EgJ4+2KOyz+fpmSQiMaUaygQxjqrriwPyh5h/7zU2sQNJB EWiqEDDCqDpnGU0RQqIjpLDiUAJhL9j3tLqko5qw0jzaY9SkYG6YQ9r5yvCknrcXfReL 7FH4mUD5Xbprz5NoIJC0YKtTvIsX0O1p9DOdUM8nE2eXC2k6qrqFbRZZ7CQlZ98fYFBt SI8bKgLyJP4p/DnIxYesfqK3S+z6nvr3FmWx9y93CfwRhXxEU9IJHL6j4xa+1RSFyIsk c3hx6ZK4sWX+ASqrMfWbljVIH7Oi3MrvmPr5wDvZbBZH9C5D+yh72HluDR7aio+TKS4N xlmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PfZHFRCK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t16si1545806edd.269.2019.10.17.07.22.27; Thu, 17 Oct 2019 07:22:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PfZHFRCK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395255AbfJPVzd (ORCPT + 99 others); Wed, 16 Oct 2019 17:55:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:46206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395230AbfJPVz3 (ORCPT ); Wed, 16 Oct 2019 17:55:29 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F281B21D7D; Wed, 16 Oct 2019 21:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262929; bh=ctx9m1P2qHO9OhbiDy0lfGlpY9jIrCPAipH0YS0yzCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PfZHFRCKW0mvsZfYjIOnpX/p50q7yAf0JZEj23WEAqnNTd1pgZoD+5aJzHJqiRjeO 7+06lw/a2jZkpd9AgXmEs/Ygu0ki9cDzjEpqgKlt0FIOmQSsHJMPGADBkTFzFFvco4 iwDaoMcVK80HCCq4Ahcf0aNTYgYpk0yVzzRjXYxA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Srivatsa S. Bhat (VMware)" , "Steven Rostedt (VMware)" Subject: [PATCH 4.9 89/92] tracing/hwlat: Dont ignore outer-loop duration when calculating max_latency Date: Wed, 16 Oct 2019 14:51:02 -0700 Message-Id: <20191016214848.563153457@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srivatsa S. Bhat (VMware) commit fc64e4ad80d4b72efce116f87b3174f0b7196f8e upstream. max_latency is intended to record the maximum ever observed hardware latency, which may occur in either part of the loop (inner/outer). So we need to also consider the outer-loop sample when updating max_latency. Link: http://lkml.kernel.org/r/157073345463.17189.18124025522664682811.stgit@srivatsa-ubuntu Fixes: e7c15cd8a113 ("tracing: Added hardware latency tracer") Cc: stable@vger.kernel.org Signed-off-by: Srivatsa S. Bhat (VMware) Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Greg Kroah-Hartman --- kernel/trace/trace_hwlat.c | 2 ++ 1 file changed, 2 insertions(+) --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -257,6 +257,8 @@ static int get_sample(void) /* Keep a running maximum ever recorded hardware latency */ if (sample > tr->max_latency) tr->max_latency = sample; + if (outer_sample > tr->max_latency) + tr->max_latency = outer_sample; } out: