Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1076880ybp; Thu, 17 Oct 2019 07:39:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIihfw9ec/hZoblu+TA3o+4u87pC+mreSudHWJs08rVjdz55UXlCWraI8yjhSIO0mYTVi7 X-Received: by 2002:a17:906:1651:: with SMTP id n17mr3777525ejd.220.1571323168160; Thu, 17 Oct 2019 07:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571323168; cv=none; d=google.com; s=arc-20160816; b=rdchmKcNhEt1G0V4n9TTl9QElLAX4TYMn0qlI7rr6SpuWx+yC0bWtbdYzlJm2l2k8d Pa9wr+mSnvy2kzpCMIksFixUMv4mi5D8IAJCxfmEj1eabhvlhV+C9pfRCthSlpghbfj1 7kBVZLdqbMCmIx0HJI6ylMA0Q6hiC9tYB+2FLY1J152iZciW50/xkdd+yiLECx5EwaRl LeN+bIlnlLqTKzJuB9UKj6GbbdxatnQxrzJhOqXO0qgpou06M6CzRqJdig/kALqSyI2k lhaejb7sSwxQd0qfIDRf39JQnNx43K29cnjO3dZDV1lSm8Y0OzjWoMZwby9NyoPtVQHH VDZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Yoqg2O4T3JUjMYVYWPNPZ3Rvpr5LBOhO0ASGhstsqz4=; b=zvyN8O4YuO2ssoS8q6lGkgqWxzuMVEvZTT/wyLluq33QP8h5WkPOn1CP9AElEjVRfK IVe7x6uFnXS042GJggN8mnMrHyBuPn3yLsgQv8iBGcalInxw4u2cX1slwyMBxia749CN 9Mr3M7p5aljyBWN4jDxQTg0gvBmdjXdRlRZSMW67BWjc9K+5mG+azKN9Y826IEEpnH8L GSZxJ6dj+IEaeYl6f5tM7NI/KoEiQe97qwDYkflG76xY8B9IZSOQ31liFXVw1BjfTTzO Mpv4vJlKF9vaXxit9ORtSxy3X8u9gS+7tWtuYHA6kfxevEr35B3eMB2f1cM5N3mFZ2MI EvVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HcPXBAAK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gu8si1566020ejb.107.2019.10.17.07.39.05; Thu, 17 Oct 2019 07:39:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HcPXBAAK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbfJPV5T (ORCPT + 99 others); Wed, 16 Oct 2019 17:57:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:48668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395417AbfJPV4o (ORCPT ); Wed, 16 Oct 2019 17:56:44 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1E8A21D7D; Wed, 16 Oct 2019 21:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263003; bh=8Em2bsmIAcI/tf3Ihod02Uq15PYbjOQsMAOdNwSUvTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HcPXBAAKzTiqlPdXsQ6seV/3ICMFLT4Qpban1IyigTKtBzCfgt5P65YO37F3O3v7L 115jhdnO1eOvCapNQ9BaQqyro7pZpDiSZHsimnEjBD2DlbvkVt3NAF4Lug3PEgGRwn a/Nxgs84SkUIknWDgtafhvNOTO2ig+7SHUOFlD0s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Scott Talbert , Ard Biesheuvel , Ben Dooks , Dave Young , Jarkko Sakkinen , Jerry Snitselaar , Linus Torvalds , Lukas Wunner , Lyude Paul , Matthew Garrett , Octavian Purdila , Peter Jones , Peter Zijlstra , Thomas Gleixner , linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, Ingo Molnar Subject: [PATCH 4.14 43/65] efivar/ssdt: Dont iterate over EFI vars if no SSDT override was specified Date: Wed, 16 Oct 2019 14:50:57 -0700 Message-Id: <20191016214832.914076532@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214756.457746573@linuxfoundation.org> References: <20191016214756.457746573@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard Biesheuvel commit c05f8f92b701576b615f30aac31fabdc0648649b upstream. The kernel command line option efivar_ssdt= allows the name to be specified of an EFI variable containing an ACPI SSDT table that should be loaded into memory by the OS, and treated as if it was provided by the firmware. Currently, that code will always iterate over the EFI variables and compare each name with the provided name, even if the command line option wasn't set to begin with. So bail early when no variable name was provided. This works around a boot regression on the 2012 Mac Pro, as reported by Scott. Tested-by: Scott Talbert Signed-off-by: Ard Biesheuvel Cc: # v4.9+ Cc: Ben Dooks Cc: Dave Young Cc: Jarkko Sakkinen Cc: Jerry Snitselaar Cc: Linus Torvalds Cc: Lukas Wunner Cc: Lyude Paul Cc: Matthew Garrett Cc: Octavian Purdila Cc: Peter Jones Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.org Cc: linux-integrity@vger.kernel.org Fixes: 475fb4e8b2f4 ("efi / ACPI: load SSTDs from EFI variables") Link: https://lkml.kernel.org/r/20191002165904.8819-3-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/efi/efi.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -266,6 +266,9 @@ static __init int efivar_ssdt_load(void) void *data; int ret; + if (!efivar_ssdt[0]) + return 0; + ret = efivar_init(efivar_ssdt_iter, &entries, true, &entries); list_for_each_entry_safe(entry, aux, &entries, list) {