Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1330851ybp; Thu, 17 Oct 2019 11:09:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdbYe+1RzsdpIa2b/LYWtufUklOok8AauKiPUq402t49yacR9BoeXVuoRHTyhT3TRngMEj X-Received: by 2002:a05:6402:1686:: with SMTP id a6mr5265418edv.174.1571335789606; Thu, 17 Oct 2019 11:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571335789; cv=none; d=google.com; s=arc-20160816; b=KFmidzLuhtKF/WNWLzbOfZXGIe6hXqpYHW5AfQfeQVNdWyVk/wbEm+V5mTKHgpJltm 673AfsAOk3o7dRYoNO86ImYSibncWzZb+sVqMgsIedUlCEet9w4Qx3W6G4pviWudk1Th ifwLr6oGLx9JAuxvNA67SI1PlamuRlNhsLmNszlVlenLoC6tJyOM0wtQTyLs4GFu5Fvp QoMeMnfHNDfhgLXxAJRiakBhYHEiFRI2ABHCZpbrY3dBKJnkwGs606UzOIgxHD2a6spG LyKQtGWO8V3bua6CtbZlBuBN0vlZHZMMFvzAh4MjFRTntCTeZwgbLoTD1Vk3lwbDCNBi 3s0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OEVyp3lgbKrEYH0Fyt5wWxvTQ4FyrcEblyuhKIhluTU=; b=IDe/erOuQZxFqJ2LbuOMsfxrcM8A89Nn2QbB42F1vumHoghh1LaKPSoTd14IW5trYL wzVTUFWjUMf2wXo2u1QN5g3e3t2HxHi9RFCNpGfbnFEzM3LBlJhVluhdD+mLNScW93eN xkjWar5fvcyGgCqNPl1TkS4dO7X52JGCnN7lmg0Ppd4pyCjIB/RwwXuqe7uCPPAncI5I G4OtvB3H0eYv44qN49gEKP2ulr/asXuXtLzRimJhq7yNe+7BVcuJlFhBaJX+uMxAr5m4 3eSjfr2YLJAsZHekN8GivEVPxx+dBW40oyr/6oKeaIAwmVHjh3Kxv3LQT+ih1wJuO2l2 RVTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x4geOQKI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si1750493ejr.33.2019.10.17.11.09.26; Thu, 17 Oct 2019 11:09:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x4geOQKI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438546AbfJPV7e (ORCPT + 99 others); Wed, 16 Oct 2019 17:59:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:52230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438181AbfJPV6d (ORCPT ); Wed, 16 Oct 2019 17:58:33 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91220218DE; Wed, 16 Oct 2019 21:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263112; bh=2CA/TObIF7zAD7BxDZiWwblm2wS1nJf0LjpiGQ58re0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x4geOQKIjOkUrMVs1ODHk49+jEO0O6TSJXtnQCmb9/AgWBfZsfnyVU9RPjeVe3HrV XdvMSSHZX8yPdyacYW0TJITt38/FX21l+XBNPtBIV7qsrAoFVEtdd4ePy0/PjBHOFD EyUea9edPw/kJcaSE6y2UVwaDvzC5y8m6kNMTdQA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Guenter Roeck , Heikki Krogerus Subject: [PATCH 5.3 036/112] usb: typec: tcpm: usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps() Date: Wed, 16 Oct 2019 14:50:28 -0700 Message-Id: <20191016214853.834876978@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 7101949f36fc77b530b73e4c6bd0066a2740d75b upstream. The "port->typec_caps.data" and "port->typec_caps.type" variables are enums and in this context GCC will treat them as an unsigned int so they can never be less than zero. Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together") Signed-off-by: Dan Carpenter Cc: stable Reviewed-by: Guenter Roeck Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20191001120117.GA23528@mwanda Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/tcpm/tcpm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -4416,18 +4416,20 @@ static int tcpm_fw_get_caps(struct tcpm_ /* USB data support is optional */ ret = fwnode_property_read_string(fwnode, "data-role", &cap_str); if (ret == 0) { - port->typec_caps.data = typec_find_port_data_role(cap_str); - if (port->typec_caps.data < 0) - return -EINVAL; + ret = typec_find_port_data_role(cap_str); + if (ret < 0) + return ret; + port->typec_caps.data = ret; } ret = fwnode_property_read_string(fwnode, "power-role", &cap_str); if (ret < 0) return ret; - port->typec_caps.type = typec_find_port_power_role(cap_str); - if (port->typec_caps.type < 0) - return -EINVAL; + ret = typec_find_port_power_role(cap_str); + if (ret < 0) + return ret; + port->typec_caps.type = ret; port->port_type = port->typec_caps.type; if (port->port_type == TYPEC_PORT_SNK)