Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1347168ybp; Thu, 17 Oct 2019 11:24:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwn3nAWz9K/LutTtpvDYTv9+r3RJadV4w+0At8ztpEZbO4+GBgDbYSwwhkI5mT1R8t6s76D X-Received: by 2002:a05:6402:1514:: with SMTP id f20mr5362444edw.35.1571336640387; Thu, 17 Oct 2019 11:24:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571336640; cv=none; d=google.com; s=arc-20160816; b=faGbWMPtDUlLL1sVUXz3wWBjlYiqaQEQ2EIQRpOLc0CilRmjvd1H8m309ob3HQoPcu PLdK5zcnALmN9s1i3v8CCmqhEqY3T12OnTK030tn0f7XnS9/Kdxhh4Y2l2p9dMZEP08J ett4xSDS0i7XGmFDRmF1fGwJVyEmZ4UfZ9M5BpLzuRcItJUJIkPpUx3AawoZR0tdxyyX LHuO0pC2dnao+nF3i73NizqZI+dr71li4wDvFkS5PZilj+xCxydkR4vgT3S8PFTp3jia I9hgBuheqSPqh9s8TUeNOJ0KNQEykSsVXJYjONFYJlsLBY995zZDFdQe+va9N8SRFxMM Vaug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OpSeiH/U8NOMf+l3n/qEgTGgrAPxsuKmnC3Z9r46FjU=; b=k7+hw7GqywSP9zgW0cIssDL4y4B8WoCr6Ja6HyijWzRTUvsyVSYWw8Av4paupY5nzN 688E/NpQflLkavHZXEsnWUzw6H49ck25vui7n0uQd7oQc+JdUpPozkxme/cZC9KXtRGj 38pmuFPt7qOBaFN7vSQvlzC8EmgfmBXVesiTmrJq9QwoXXXM/Pbarm6vyzmIT93gzUyy m0doa+fVu2t0YlSod01b5AsRyZqrRLgoISJn61rrdVfbAuBNr274DXmsd6EE8RHVNUC1 AUNhaUmPxTGvqGcOoo7ddbEZ0mBqtHCeUVF4l4rN4Q3jAaINyXncQG59nbAwmr9Rh6tG NX5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f+gaMMpP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jx20si1800320ejb.291.2019.10.17.11.23.36; Thu, 17 Oct 2019 11:24:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f+gaMMpP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439044AbfJPWDE (ORCPT + 99 others); Wed, 16 Oct 2019 18:03:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438498AbfJPV7b (ORCPT ); Wed, 16 Oct 2019 17:59:31 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 183AA21D7C; Wed, 16 Oct 2019 21:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263171; bh=TZAzt8b0InQqkoVFvO0WAITq7FHov/uXFi2a0LWBaNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+gaMMpPvZML7tZziMlcLG/BEbj2gW8f10u3dIkV51RdfN3Xg0FKhxJPiQ/6FVwdh y/yuSFTLjKJ8tlX7+u++zQfZSAr/mvbkA9x1nFRhpEzoUsxYk9OaBCQrvsugLVH43S gp/9JHu+z4XoiJ6NcSUYarzHRZFFpti0FNkknu9Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kenneth Graunke , Chris Wilson , Rodrigo Vivi Subject: [PATCH 5.3 098/112] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Date: Wed, 16 Oct 2019 14:51:30 -0700 Message-Id: <20191016214906.224784666@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kenneth Graunke commit 282b7fd5f5ab4eba499e1162c1e2802c6d0bb82e upstream. This allows userspace to use "legacy" mode for push constants, where they are committed at 3DPRIMITIVE or flush time, rather than being committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11 both use the "legacy" behavior - only Gen9 works in the "new" way. Conflating push constants with binding tables is painful for userspace, we would like to be able to avoid doing so. Signed-off-by: Kenneth Graunke Cc: stable@vger.kernel.org Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20190911014801.26821-1-kenneth@whitecape.org (cherry picked from commit 0606259e3b3a1220a0f04a92a1654a3f674f47ee) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -1042,6 +1042,9 @@ static void gen9_whitelist_build(struct /* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */ whitelist_reg(w, GEN8_HDC_CHICKEN1); + + /* WaSendPushConstantsFromMMIO:skl,bxt */ + whitelist_reg(w, COMMON_SLICE_CHICKEN2); } static void skl_whitelist_build(struct intel_engine_cs *engine)