Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1370097ybp; Thu, 17 Oct 2019 11:45:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyuDJ2wv9tvOVHKXRPhJmUaUK7gwxVYlrSZ3npifjS9FI52FFQBKja51g7DHiyuqNS3mqhM X-Received: by 2002:a05:6402:149a:: with SMTP id e26mr5357061edv.123.1571337949992; Thu, 17 Oct 2019 11:45:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571337949; cv=none; d=google.com; s=arc-20160816; b=KGnl56k5Tm1NbHi0Px86mHLQBcZjpCjFXhSyaEImgWhNF4Rvj5WQxbz8C4lj3qrQBW VmPUtMQsCeIEcxh7sT/h7z79Bwbs50cGJgcDAP+3LZc+AJj98ETL1mb9qjC8sW1fzLho QRUxBcjFjyuEr3EwaNtOsMF4470S0m8iE/jp0hHVK+aywhwt733e1TtmHo8E1FJOKfPH MPs19RrdLdgK2GoZGisoHXmGDsaihQD4EmL6GDUZSsNHAVNiU0W6N2sao3qzY5/bV50p AjI+8RyUj9DaAuklOT3EbiUHAa+1CDTkOL4oDABqQKWR+8S73i3SHHrwSs0YhLFbyBbK kkTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2nuXp5qsc0d8qhDgABvRKmC7Z+W4ce2JwHEfLEI5ucI=; b=mp3ivZTjREFvAkTI3/c1MO0xY4cLX7oqK9lkg9g41hF2LWhdnwqwBnzvXy/ZbnFK4J UuyGTX3FoZYzz5q6jPYa5l7PIKGmjLi//fJ41cmSRUTLiQTGexL4jfrsvT4c5yMQq3Jr Oho38a5l3qqmCPWmAB1fybSbCw0xoJe6i74KhExuk7oDFWQmoMowp72F+ERVPn+UZDeS g0K1SQcid8NGRQ3nBssrab4dk5+f4Y869weCrk8dRhLKmUZ8TwYC0h6uO29/oBnatahS enffxLQ1PhSeLt5YYL4ZwCLCihsWK+A8fs77XcYXbEW8AzuZSYMy2LNu9jHJXj2+30hq vdgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OVvq6luL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l45si2347125edc.185.2019.10.17.11.45.25; Thu, 17 Oct 2019 11:45:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OVvq6luL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407235AbfJPWKi (ORCPT + 99 others); Wed, 16 Oct 2019 18:10:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:49606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437958AbfJPV5K (ORCPT ); Wed, 16 Oct 2019 17:57:10 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59F1721A4C; Wed, 16 Oct 2019 21:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263030; bh=lt385UfrJF89sF7JHdA5gMeIVFsDC8oOelDqQLBCJ0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OVvq6luLrBvJLsZ08a7v4I4qAUmtcUErWPX3ceNd/yh0+1ETr5HaaFhO2T4iWaKwZ WdM3YEdW9P9PJtAFOjopArX7o3XwGULke0J62PYsdbwgpVlTMlt5+4keCS6pxz8Ln/ YpzMeqQocnEqKI2rpUCJ4QwpsCf/E8Sj6C31b5u4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com, Johan Hovold , Oliver Neukum Subject: [PATCH 4.19 31/81] USB: microtek: fix info-leak at probe Date: Wed, 16 Oct 2019 14:50:42 -0700 Message-Id: <20191016214833.347317046@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214805.727399379@linuxfoundation.org> References: <20191016214805.727399379@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 177238c3d47d54b2ed8f0da7a4290db492f4a057 upstream. Add missing bulk-in endpoint sanity check to prevent uninitialised stack data from being reported to the system log and used as endpoint addresses. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/20191003070931.17009-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/image/microtek.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -721,6 +721,10 @@ static int mts_usb_probe(struct usb_inte } + if (ep_in_current != &ep_in_set[2]) { + MTS_WARNING("couldn't find two input bulk endpoints. Bailing out.\n"); + return -ENODEV; + } if ( ep_out == -1 ) { MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );