Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 Oct 2019 15:10:25 -0700
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Mark Brown <broonie@kernel.org>,
        Richard Leitner <richard.leitner@skidata.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Igor Opaniuk <igor.opaniuk@toradex.com>,
        Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control
Message-ID: <20191016221025.GA990599@kroah.com>
References: <20191016214844.038848564@linuxfoundation.org>
 <20191016214907.599726506@linuxfoundation.org>
 <20191016220044.GB11473@sirena.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191016220044.GB11473@sirena.co.uk>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote:
> On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote:
> > From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> > 
> > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream.
> > 
> > This control mute/unmute the ADC input of SGTL5000
> > using its CHIP_ANA_CTRL register.
> 
> This seems like a new feature and not an obvious candidate for stable?

there was a long email from Richard that said:
	Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute
	outputs on probe"), which is e9f621efaebd in v5.3 replaced
	snd_soc_component_write with snd_soc_component_update_bits and
	therefore no longer cleared the MUTE_ADC flag. This caused the
	ADC to stay muted and recording doesn't work any longer. This
	patch fixes this problem by adding a Switch control for
	MUTE_ADC.

That's why I took this.  If this isn't true, I'll be glad to drop this.

thanks,

greg k-h