Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1375845ybp; Thu, 17 Oct 2019 11:51:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCYCkuXniwRpaqTWZAmxa9akltLR32tKFr3Xkip26JOt89mrapf9IIOwryCFZ09eEk7FUm X-Received: by 2002:aa7:d389:: with SMTP id x9mr5475939edq.33.1571338307921; Thu, 17 Oct 2019 11:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571338307; cv=none; d=google.com; s=arc-20160816; b=MKco3k4YrxD6zB7rOgNAJAImgk6tFAiPjN+B5/8uCp1yO5OEARSr96FiplNbufNWl/ us7B6tmTkImddynVnC8CoEZ1iJsEAoPhyllgzO2N6QknGrExzU7HFNWAwqsVeIHMNjpo PapALQI72o0T6fOgY+G3PxNIlCf4Wduy3nyYpzt5ObvB87T7mMSIC65Xd4iHt8VuMIdI RvK5XCuQ1ELICdNwyrNlSCOFB+KrPOo7/ikogZ09hpjs8/YG0EYQjNfoSgNnjkIoVSGt FE8scQGIZPq2yAwTqacRORz8Xei+kyGrzpPhbrOP1biXUYCg8Q3gD7tcbASd6NZaiNRr Tbig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sUSX/RKwZrGx62ZssPzvCr3glBe4s66JAfmCUCoJ5G0=; b=S4ZtQJYbbXtSTeFeMfImP3fSlPwB68zmzTot8WYl86fypSd/xUXPaKOC91uFD1jILp jPoRDyeejN6xVmWKklYjPxlNha53HMzMU5PtJjMrkDmaQ30sJ9Groq+hmZ3k79MH+Etd 9ZdNzMHc71P/D7giSSTUd4iV/YGrKt4WsR1nCQjCEWIlJlHwfEwyYP01h/bFceUdyTJL r70TwY3Ep5xGK+wnaVOmC9Eb4dZvXEbwi5p+k/I2wxVZYrs1f0nUf5zwYnp+ZA/+xbWi QO53rBwMc6yJyexJBrIFKShxxEwzWotPXgP+pTkKwlaccz/X7tFM7ZpVpNC4vW7DU/th Ua9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uir8u3Bj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id by16si2055360edb.30.2019.10.17.11.51.25; Thu, 17 Oct 2019 11:51:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uir8u3Bj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407280AbfJPWLV (ORCPT + 99 others); Wed, 16 Oct 2019 18:11:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:48870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391393AbfJPV4s (ORCPT ); Wed, 16 Oct 2019 17:56:48 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE92121D7A; Wed, 16 Oct 2019 21:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263007; bh=Y8vjRB1HKyf86CsVZF6f3sro0+PODNZ0qgmKF8X/scU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uir8u3BjWw/QNbs5H2joU1FUxAZ5+iX0QzU56e59X3MrXBDEXFklY2mbCuUUqGw0m RTgRuiiSFWfUicc20mRmwL7h/AcqckmsFWgKabTF7pP0Zm94yxGaeASpvPJXxSarlQ 8jyrZjaCsV0nuqNMNwamaYVJQoAaYUtTuxBk5wqM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Will Deacon , Xogium , Kees Cook , Russell King , Ingo Molnar , Petr Mladek , Feng Tang , Andrew Morton , Linus Torvalds Subject: [PATCH 4.19 01/81] panic: ensure preemption is disabled during panic() Date: Wed, 16 Oct 2019 14:50:12 -0700 Message-Id: <20191016214806.623585425@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214805.727399379@linuxfoundation.org> References: <20191016214805.727399379@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon commit 20bb759a66be52cf4a9ddd17fddaf509e11490cd upstream. Calling 'panic()' on a kernel with CONFIG_PREEMPT=y can leave the calling CPU in an infinite loop, but with interrupts and preemption enabled. From this state, userspace can continue to be scheduled, despite the system being "dead" as far as the kernel is concerned. This is easily reproducible on arm64 when booting with "nosmp" on the command line; a couple of shell scripts print out a periodic "Ping" message whilst another triggers a crash by writing to /proc/sysrq-trigger: | sysrq: Trigger a crash | Kernel panic - not syncing: sysrq triggered crash | CPU: 0 PID: 1 Comm: init Not tainted 5.2.15 #1 | Hardware name: linux,dummy-virt (DT) | Call trace: | dump_backtrace+0x0/0x148 | show_stack+0x14/0x20 | dump_stack+0xa0/0xc4 | panic+0x140/0x32c | sysrq_handle_reboot+0x0/0x20 | __handle_sysrq+0x124/0x190 | write_sysrq_trigger+0x64/0x88 | proc_reg_write+0x60/0xa8 | __vfs_write+0x18/0x40 | vfs_write+0xa4/0x1b8 | ksys_write+0x64/0xf0 | __arm64_sys_write+0x14/0x20 | el0_svc_common.constprop.0+0xb0/0x168 | el0_svc_handler+0x28/0x78 | el0_svc+0x8/0xc | Kernel Offset: disabled | CPU features: 0x0002,24002004 | Memory Limit: none | ---[ end Kernel panic - not syncing: sysrq triggered crash ]--- | Ping 2! | Ping 1! | Ping 1! | Ping 2! The issue can also be triggered on x86 kernels if CONFIG_SMP=n, otherwise local interrupts are disabled in 'smp_send_stop()'. Disable preemption in 'panic()' before re-enabling interrupts. Link: http://lkml.kernel.org/r/20191002123538.22609-1-will@kernel.org Link: https://lore.kernel.org/r/BX1W47JXPMR8.58IYW53H6M5N@dragonstone Signed-off-by: Will Deacon Reported-by: Xogium Reviewed-by: Kees Cook Cc: Russell King Cc: Greg Kroah-Hartman Cc: Ingo Molnar Cc: Petr Mladek Cc: Feng Tang Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- kernel/panic.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/panic.c +++ b/kernel/panic.c @@ -149,6 +149,7 @@ void panic(const char *fmt, ...) * after setting panic_cpu) from invoking panic() again. */ local_irq_disable(); + preempt_disable_notrace(); /* * It's possible to come here directly from a panic-assertion and