Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1401068ybp; Thu, 17 Oct 2019 12:14:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbyBlElppJY/+tEyT3dcA/YRTNoiV+Lr1YTURa9+ktgmscGMasckgMpnfBWzMMOb0WrVK6 X-Received: by 2002:a17:906:11d8:: with SMTP id o24mr5112094eja.224.1571339646133; Thu, 17 Oct 2019 12:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571339646; cv=none; d=google.com; s=arc-20160816; b=MzsfkbDrOLe0X/XaVGAan/d9b3mY7M6xc/jzDyD3MjCy+DFWsurwQ6c8MdbGhUpXmm d59J7EqMEkChb37XjBQkCW9U2WAvowRSs1anppjQvcLGoZd+sYukHUIG13R1/2X3e+kn brI46PudI/MTZYIVd+E3wfe9AA/GlEpKkLXBFyRbEGZpie1PVORsjkwljcuQQgglhc/p fIVo8f2YTb5kkB+bVxsuMV5tdXm6zhSeamdUyRnS4r62wchGlOqAS8ZuC1gO266hN86G lKzgiecOdWzP6aRWh24gO7k2IC06qP9bRkbAkSMH0i+QWH3Vgtx3uUpPhIdQv3vwSEr2 XqIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MNJAiSxbI0evDqGnidF4ClD+tTfrsopFGSnaZOBiQ/k=; b=wzN7BYEJ4LgnUN+7hr8EKwf0wH7MP/GhJ98alIU6ivRb1MRbYllekD3uY7UJ+I7lJc TNVEemOyhsdnjX3MiuJ8a/r7DhsKwJ5NmeyoCVrhK+aoCF0s8CXpt7ZyX/LUJNHH/t06 eh9PDHRyuzZrZv8Q3OzUo/3M3iO6X9lSKepZzTd/8tN1DXWLbi0JbtUzXA3XcFq13abC M+5JxmwZBLJqtn0luhhN2oBKAQwvwgU6couNLelq8O/U9Q12fBcUckoHGEf8qI0/Z9BR DfsBSTJZ9eXvGKsJfeDLKv8ROojzf4dWKG4PDaMzTkZXh7u9RkaZx9gKQlP7bKmahkKk BptA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sPsbSneW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si2037655edo.14.2019.10.17.12.13.42; Thu, 17 Oct 2019 12:14:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sPsbSneW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439312AbfJPWNX (ORCPT + 99 others); Wed, 16 Oct 2019 18:13:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437843AbfJPVzy (ORCPT ); Wed, 16 Oct 2019 17:55:54 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD5C4218DE; Wed, 16 Oct 2019 21:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262953; bh=j6J6/XrfGH0dGCQ64DCTclHY+iBTFT8Fgdv2TEDikSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sPsbSneWmjkLIL6ELXtQuK46gKUxmF2Z9PlO0E2VAhhxLVsB8U9UHEpsp/hDFJvtf Lj4XQ/DZcKwxPAX58Tb77JAWQl8g4ZmKV4TYmM2/WuwEOJWVfOb3/iL4PSbnpf11sF mgBe5rmVx/5eDZYFF9bl/J3yuCHdarwRa7SPnjs0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , Peter Korsgaard Subject: [PATCH 4.14 23/65] serial: uartlite: fix exit path null pointer Date: Wed, 16 Oct 2019 14:50:37 -0700 Message-Id: <20191016214819.179163209@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214756.457746573@linuxfoundation.org> References: <20191016214756.457746573@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap commit a553add0846f355a28ed4e81134012e4a1e280c2 upstream. Call uart_unregister_driver() conditionally instead of unconditionally, only if it has been previously registered. This uses driver.state, just as the sh-sci.c driver does. Fixes this null pointer dereference in tty_unregister_driver(), since the 'driver' argument is null: general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:tty_unregister_driver+0x25/0x1d0 Fixes: 238b8721a554 ("[PATCH] serial uartlite driver") Signed-off-by: Randy Dunlap Cc: stable Cc: Peter Korsgaard Link: https://lore.kernel.org/r/9c8e6581-6fcc-a595-0897-4d90f5d710df@infradead.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/uartlite.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/uartlite.c +++ b/drivers/tty/serial/uartlite.c @@ -746,7 +746,8 @@ err_uart: static void __exit ulite_exit(void) { platform_driver_unregister(&ulite_platform_driver); - uart_unregister_driver(&ulite_uart_driver); + if (ulite_uart_driver.state) + uart_unregister_driver(&ulite_uart_driver); } module_init(ulite_init);