Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1405136ybp; Thu, 17 Oct 2019 12:17:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpsvqZQhMiuhIuzbIxVh94HwP7pLoPPKVFv2/IL9Qkdzm2XsEelPehXNH3bSKeTiTci4jR X-Received: by 2002:a05:6402:7d2:: with SMTP id u18mr5692262edy.23.1571339861090; Thu, 17 Oct 2019 12:17:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571339861; cv=none; d=google.com; s=arc-20160816; b=BfTiBwkbQ5hCjGouFiqr6WSPR0ZXx1IFFyb1nDZ46V+CxLOcAmCR1JOwb1R806b2ei CYTYzczxPIVZYBr9I0/2o6n4EYmGASKlhmNwUqSTaQGXKy5HA+0laXBzuvuNKfqUbIGk JYfqjJQ8D/cqOSGvQMJUan3i9y8ohP7QnK0O8xeCePQkBBSMlEkxwPIUi0xfRjUcpT4D HtXgEPdtqHSqIF4FNNjXHR0OUpEVVnkVrnkcPglcwpfh56ym0KRf8/3QldhUjYSKYly0 P67H63Jz6paAp6GBzTk9hQ6q0M/7kQXjUoSSqkR1vGqla76BzbQn6xSHoenDJDZ/MypS W/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J0jfptpvgOH9Z259906jHCcujl3ek/2Na2wrUrA5kNw=; b=Amt4lTV7PsRSkXVikRbbR1Xjrus/iJpjdx7lHVBe6+Qy9GIXPgcuxPVG1azjx67dMW 1qRi9AnoVW5EwdD5IPsw4l87g8hELRBayfS2JiWlWDHkgIClbWBm/DN5w0qnXfCaBm4Y lElPaUnFvYgITlSOvyYphwMDWv1RpBu6v5Gpfyny7TYVCBsfopxuI24K3VGpI+tpluBC oT+PR0HS7f2Rls0s+a6QtQmgJl3qgZ2eyD3ZwvpPmJdej5LWgPtNKqKGivWX7sO+rkXn 2LtCARubGJm/vSKqx4t4Yk2lv+HdV4u9LWo/ZEjcsMb9wmXgxOL2e2NFwmvd8P2LYzfW YqOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UKpMufj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12si1953465ejp.103.2019.10.17.12.17.17; Thu, 17 Oct 2019 12:17:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UKpMufj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407421AbfJPWOv (ORCPT + 99 others); Wed, 16 Oct 2019 18:14:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:46550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395281AbfJPVzi (ORCPT ); Wed, 16 Oct 2019 17:55:38 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AC2C21D7F; Wed, 16 Oct 2019 21:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262938; bh=6LrAYEbdMfC72hEYHwUkCFcp0eNshDeqxzc/E+tndRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UKpMufj8OrFQfEP54cMdXsdjxjtGpwEUc2ssetCIUve8xQ5JDMEUsUTKPEX76xvJ0 NctE7qj6yNaMc0uFx6GkH/3NcGYI43WfLbGbFs0f1Txip9l1Z4xK4e1RjhvSAOO1W1 IncPUN3oA912Vqh+ulYo2pZRLuIvnYVhXDqv28gc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 50/92] USB: adutux: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:23 -0700 Message-Id: <20191016214836.037717890@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 123a0f125fa3d2104043697baa62899d9e549272 upstream. The driver was accessing its struct usb_device in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: 66d4bc30d128 ("USB: adutux: remove custom debug macro") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c @@ -152,6 +152,7 @@ static void adu_delete(struct adu_device kfree(dev->read_buffer_secondary); kfree(dev->interrupt_in_buffer); kfree(dev->interrupt_out_buffer); + usb_put_dev(dev->udev); kfree(dev); } @@ -680,7 +681,7 @@ static int adu_probe(struct usb_interfac mutex_init(&dev->mtx); spin_lock_init(&dev->buflock); - dev->udev = udev; + dev->udev = usb_get_dev(udev); init_waitqueue_head(&dev->read_wait); init_waitqueue_head(&dev->write_wait);