Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1406642ybp; Thu, 17 Oct 2019 12:18:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2BXCGPKABZx6oGkBnHM183erTvpjVPlBpp9xcoTTnaKvKgK5Z5cClrmqqOe4Vry9J9bWM X-Received: by 2002:a17:906:bcdc:: with SMTP id lw28mr5088512ejb.183.1571339939835; Thu, 17 Oct 2019 12:18:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571339939; cv=none; d=google.com; s=arc-20160816; b=zZ3OicoTUMK9A/zNVDn8KI7imVOJGat9/ke6SMsso/FI3Q+WwN+k+Pf+sfzJLqZTuK MfUo/tSbxr5M4t9Zzty2cwOWfB4TPbn2pRjpHrMLrzh+idIoLKcqvaujx9+DY172aLcZ PsKSBgziN7CJQnk4Xhlc7jaMTwOdHDUBWzVRQ/ScasI05Llqfuek7ZvgTjelLYWQ3xtP BrmRIQMGsV9QL/6Ak+q0GkxQsc+aGdVf9f7SZNAzv3hwbON/PnN/KVefym02689s1PQA vmdW34PP23j/aakRkmtMXiOwogssnxDIWoLGrQPfhmxQx96TS4aizFQk8SpfuU1V7gPx pqPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MNJAiSxbI0evDqGnidF4ClD+tTfrsopFGSnaZOBiQ/k=; b=eDtku7nuvRbE93VAPvU4mkTOuhX4S+OrP8S4mPT2SvVcmw5xu15IySNAFvZ0x4JyhL LLHt8h+nQ2xPuqK5oOZEXDQFgU9nWq6lWk0cttv1P/EKbXINt6ArArzzs7FPgRcfur3i sEkBy0j2xSLSKNJVwsL9j/4uEYTrY9T0yhHN46HeV2UThPaakOijtXVBKzWnzoeXdQyD 0NVwQ7B9UujRIsGv7X7D0nf6gdLz2pJa0EKgcRkKnyVJ2EiPSNJMM6RjOVn5M85XfuHr hHDeCxR2FdCllwyoDS6OvNzMEx0qSFBjYYrG0gSL44N/nRtu30e6uPzNpSIJguTlZ8ot 4qzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="GnIb/f9j"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b33si2276737edc.265.2019.10.17.12.18.33; Thu, 17 Oct 2019 12:18:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="GnIb/f9j"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405611AbfJPWO7 (ORCPT + 99 others); Wed, 16 Oct 2019 18:14:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395267AbfJPVzg (ORCPT ); Wed, 16 Oct 2019 17:55:36 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B599222BD; Wed, 16 Oct 2019 21:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262935; bh=j6J6/XrfGH0dGCQ64DCTclHY+iBTFT8Fgdv2TEDikSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GnIb/f9jhiTxU7b8PwWYcUSbcDgoZZ9bOBF16b9KIquSqmNgGaA7lB9uz9VgTFyo0 VDuIdB8wweARIFoPKjHwxioRzXLSK5O+yCcRI98bOvJN7pMJE4Ofcz55x23pl9mAyS 61U3ECOnbV4/XLIuoWZU5y5CzjajYQd0IYv+ZWS0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , Peter Korsgaard Subject: [PATCH 4.9 57/92] serial: uartlite: fix exit path null pointer Date: Wed, 16 Oct 2019 14:50:30 -0700 Message-Id: <20191016214839.294596520@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap commit a553add0846f355a28ed4e81134012e4a1e280c2 upstream. Call uart_unregister_driver() conditionally instead of unconditionally, only if it has been previously registered. This uses driver.state, just as the sh-sci.c driver does. Fixes this null pointer dereference in tty_unregister_driver(), since the 'driver' argument is null: general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:tty_unregister_driver+0x25/0x1d0 Fixes: 238b8721a554 ("[PATCH] serial uartlite driver") Signed-off-by: Randy Dunlap Cc: stable Cc: Peter Korsgaard Link: https://lore.kernel.org/r/9c8e6581-6fcc-a595-0897-4d90f5d710df@infradead.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/uartlite.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/uartlite.c +++ b/drivers/tty/serial/uartlite.c @@ -746,7 +746,8 @@ err_uart: static void __exit ulite_exit(void) { platform_driver_unregister(&ulite_platform_driver); - uart_unregister_driver(&ulite_uart_driver); + if (ulite_uart_driver.state) + uart_unregister_driver(&ulite_uart_driver); } module_init(ulite_init);