Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp227812ybg; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqyILWBI5ym81J495nukPJR8xQqRKmR6CADOC8LyKOdMCr1Kdwu3uoEKuYd+CCmgkAJldQOX X-Received: by 2002:aa7:d8ca:: with SMTP id k10mr7823079eds.54.1571374752771; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571374752; cv=none; d=google.com; s=arc-20160816; b=HsKsR6enAM1GhfTKRtCOZEVn0AKr/Fo1fzHZpqY30Z7ZJH0vEivBG35ZDtRhLb3IFM E3QORZMYW92yqpH7etxmR6ZtNdgzBxH7JwDPRIJKQbnh9HuxJTVp9ggztdl7LfBR9fhV DgUpjetTlo66mW1x3VTrvQXNDWeWQeYPiQkhgvGfQnTPnYUOyzEmxUDD88C6we/5JCAQ VPcXZq1PHDqMz1IQ6Oz+ItcRm4bpd8tSPT/yI8MgeqBJ+UhKUDcs/WVrRk5vHhHc34/5 lSi150BS8q0XqLY0qQxkLXWNrNNCz9pP7fbkd8Zmg+Fp8OZeL/QuTHKJUvKJ1xjsrxD4 T2ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YKBJVq8LVpna/nSz+hLLZLmT54cJAMTo9qANT0WN8eU=; b=YW8spN/BeNgiXqAep/0FtggLzZokvvp8yQtepsQUxJyKw/XLtZTJGaDesCK9Ir7JGS tjvPq6psQOIvoDoz18yRSJBT0pboES1rGm0WOUsrXmNnYIFRJ3FBEi8sWY8S3Aqnv8Ca d93wr4LHQOIRD7imobDuumJp4QFqKAzxu/3T6++bMNIYP204UdciJnJvBDn+jb+L2lrI rSf+7KnlDL9iGQSKQmaO6H8PifBhR2g70DGq/HwkwUfWxD27bPSE4xyXLQ0Jc4hdwisI OpK+lzxIbgNrVx0T07UhaSzoQfSh7FFU92FjVLEaWIbb6CZJQ4ysxbWowI2hum18DXI6 5K3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rtIDieVk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b42si3148705edb.11.2019.10.17.21.58.06; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rtIDieVk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407450AbfJPWQM (ORCPT + 99 others); Wed, 16 Oct 2019 18:16:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:45654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437720AbfJPVzN (ORCPT ); Wed, 16 Oct 2019 17:55:13 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 867E7218DE; Wed, 16 Oct 2019 21:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262912; bh=MtMGiH1G0XKLabeSTO8c9Lk4TLaGXAQt/nU9VQmTvOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rtIDieVkTAj9JMLWLZaPiFSak380oMrFwLORWSOMqSs0yfqIcsWCTWZqnnzLuQtKw 5mN1Y4K2ujzC22o6sU4CWL8TRRnlx/wQh4vUBIj/iK6Jl5X397sGKJvc/TkXI6dhJl /QYHJ/7TyDrowes2aq9S/dCHj7O3/l/nMIwm0zAs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 72/92] USB: legousbtower: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:45 -0700 Message-Id: <20191016214844.418325456@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 726b55d0e22ca72c69c947af87785c830289ddbc upstream. The driver was accessing its struct usb_device in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: fef526cae700 ("USB: legousbtower: remove custom debug macro") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-5-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -302,6 +302,7 @@ static inline void tower_delete (struct kfree (dev->read_buffer); kfree (dev->interrupt_in_buffer); kfree (dev->interrupt_out_buffer); + usb_put_dev(dev->udev); kfree (dev); } @@ -818,7 +819,7 @@ static int tower_probe (struct usb_inter mutex_init(&dev->lock); - dev->udev = udev; + dev->udev = usb_get_dev(udev); dev->open_count = 0; dev->disconnected = 0;