Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp227814ybg; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqxw1AU4jHreN6NKlpHUisOVT34LaJI0vyRE2iDVTyYcTGzg5QvO+MU8DrBUZVlVZDBpwUko X-Received: by 2002:a17:906:6dd3:: with SMTP id j19mr6753681ejt.144.1571374752775; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571374752; cv=none; d=google.com; s=arc-20160816; b=ms1rO5JqALSMQud3em4a3lx464jgw4XWBEr/uQWbAlcgfaAquGn04MmOJcjCAHiPzF aS1pxthXkweBR167S2YEUqIjGaTQyZqErImX1/7NaMysBtnVxYW/r1KN65qjXYWndUZx eDDN75MkmrKsah11j0faCjB2r3yAR0Qb4xC/JjD1yFnXoY7J+OYrlHHO5lzAR7t7WPHV woF+OvVDloc6K3NXk39efLDk9bn++emVGxrhYKaXfY8RV0hejJ+igY25rObDngS4R13z 6qUTlpbBsu4+tt+gsvCC24uxcQPWv8Pk0y2TA+2W4h83tlsRvJNrUnIX2Xe5bQJBWYxh UniA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZxwaajRCLz6Yjj7KtjPmAD9dfLKyTGJ7mfgGEy1tA5M=; b=nFFTj4pmqPH93TClyDeb0SoiZsvtAFqva5LipN9IE5TBO6xQI64EwaOZxmqhq1WXur mkfQXzTdZEDGMXxy6ARR+a/vA6eej0PJZQl6+hWc/ohbZu5mCsldlY6GzXe180q2bYrw oxNDz0RosfIda9lV6aNN6bnUkWOGbu9yAng7QToAPyHtUNVIIyIxHAUqmJRLMqzALRsy YTMdGy4zwj3ntxcilO0YxTfGU5XYYMGumpEBh+0XDX9WpnczIkMak9Zm5gLzQiRwvT6j r/7siECAOQXWRamLP5DTxjjKtNr4ONbHkTnqeEXSZmcyr987Ugvxr58jl1FemLzioF/H SMew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D7hVxwcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si3263613edj.43.2019.10.17.21.58.10; Thu, 17 Oct 2019 21:59:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D7hVxwcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407477AbfJPWQ0 (ORCPT + 99 others); Wed, 16 Oct 2019 18:16:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388653AbfJPVzK (ORCPT ); Wed, 16 Oct 2019 17:55:10 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3014218DE; Wed, 16 Oct 2019 21:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262909; bh=bU4CuMd2VNYjjpDGrnKUfxlztZgEPyz8hEzwiyxPeGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D7hVxwcLp3oza5FPfK7M2OOnZyzaFJYAjZRqMTaue+GKpVxniYmku2HzoCJ46pqfP oshSnHWh4Sajmi+ldQzXbxI+aLouXVXpYHpOBOy+3StoTE+UXNz/C9iHNGrtbEyQSF +LT4M+Ci4Ncf0cqGWayMLVCN2jMrP09K6tG6SR8k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 52/92] USB: iowarrior: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:25 -0700 Message-Id: <20191016214837.207999160@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 80cd5479b525093a56ef768553045741af61b250 upstream. The driver was accessing its struct usb_interface from its release() callback without holding a reference. This would lead to a use-after-free whenever debugging was enabled and the device was disconnected while its character device was open. Fixes: 549e83500b80 ("USB: iowarrior: Convert local dbg macro to dev_dbg") Cc: stable # 3.16 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009104846.5925-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/iowarrior.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -248,6 +248,7 @@ static inline void iowarrior_delete(stru kfree(dev->int_in_buffer); usb_free_urb(dev->int_in_urb); kfree(dev->read_queue); + usb_put_intf(dev->interface); kfree(dev); } @@ -776,7 +777,7 @@ static int iowarrior_probe(struct usb_in init_waitqueue_head(&dev->write_wait); dev->udev = udev; - dev->interface = interface; + dev->interface = usb_get_intf(interface); iface_desc = interface->cur_altsetting; dev->product_id = le16_to_cpu(udev->descriptor.idProduct);