Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp228242ybg; Thu, 17 Oct 2019 21:59:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMRe7Un2CrjDdVtaUIKmk6I1n4DS9FpGre6Wfqx77mmbtvf9DfHqU3uW8WO43hzMeKSL0/ X-Received: by 2002:aa7:d8c6:: with SMTP id k6mr7617142eds.87.1571374781756; Thu, 17 Oct 2019 21:59:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571374781; cv=none; d=google.com; s=arc-20160816; b=HRxrCvJNOZzNJI4dt3wV+XeB7lWxPD3pmSYAiOVOfYoDGuzrXVJ6XdSz2zU+84ifKJ meMEjwOsoQDoV+HL/5zUkSFjA9ao81IIu51OZ28Bpj5d2QxZliOX48Rc1Wsj6Z7kCsKh eVheQwOM9Nxnx48Qgdg9SaovH4EGFUYgVtFX60ip5+KQI4ZFHvEfHxqoZfNht4XlkhjA z9lW6cIgVznPXjawZhKv9gBjThKFaB6OR8PWf8Z3zC3kYpJ43yGO0t/7/zaQ6mekJZ7p peM7BFcDuY6TKe82LzNtNrYs4HXPfme06YUyPDpNGwhc7qUZBBe3IMo+EaslIPQWZvnQ kWMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7/NBuRINX2WE8ha2kFFy+qUA5GABPQ/AK2q2PuJHRuM=; b=CYaC7jy92T2o+L82dtWyflDspLERS7Bfl3k4K5o/v0q0rf3zo/aict57z473ad8Yfq T7++OOzQJCzziE4b3v/ZkZUrtSqSFXu6xUBj7gYjp60ytdKkn2Ci1+mCdV92Yqb47tZ0 vAqul/ZRXCGKDh3Zu5lp4oetp9besK8G2kFQG8Wqzr+HICZ6eBgkm3W+EFQ9TyjwKrJY 1wEY4Eojjetx4ngz3D5Tc9ABmYFZxSNY1HXys5rlcLKkXmpSLprI6LXofik02XPa6Rro oaO8+ROenPzJlKXYiY1sidU8J22iZ0h/Cqtph3eCeQ3ttU+l9hE1k4EfWx55KYYg+IUX fFrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lruisrMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f43si3415645edf.422.2019.10.17.21.59.18; Thu, 17 Oct 2019 21:59:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lruisrMN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729574AbfJPWRN (ORCPT + 99 others); Wed, 16 Oct 2019 18:17:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395107AbfJPVy4 (ORCPT ); Wed, 16 Oct 2019 17:54:56 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6506C218DE; Wed, 16 Oct 2019 21:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262896; bh=9CZK8fiOuOEEttmvAJF3qxboAumotw1zuT9VWq4eyVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lruisrMN5YFOBippyRKhsifA7Zrr2OlOzwZF+R9jQTwRrksEP6sFAe6K4AUb6DEbk hmFQ5SVBs1lvHl6J59Wc542cP3Udaw6tFPfIzMECaOUv/TR84f/xM5Mat3bkGxIJqf pm9fnHvvFCGmbBW4Wpv+jJrI+R7vMqJjvZEylpgA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Aring , syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com, Johan Hovold , Stefan Schmidt Subject: [PATCH 4.9 13/92] ieee802154: atusb: fix use-after-free at disconnect Date: Wed, 16 Oct 2019 14:49:46 -0700 Message-Id: <20191016214809.607606326@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 7fd25e6fc035f4b04b75bca6d7e8daa069603a76 upstream. The disconnect callback was accessing the hardware-descriptor private data after having having freed it. Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver") Cc: stable # 4.2 Cc: Alexander Aring Reported-by: syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/atusb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -838,10 +838,11 @@ static void atusb_disconnect(struct usb_ ieee802154_unregister_hw(atusb->hw); + usb_put_dev(atusb->usb_dev); + ieee802154_free_hw(atusb->hw); usb_set_intfdata(interface, NULL); - usb_put_dev(atusb->usb_dev); pr_debug("atusb_disconnect done\n"); }