Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp232667ybg; Thu, 17 Oct 2019 22:04:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyPx75OAQKHTXEJqQb7VsT2TcH9XvUOsVR5FM1HjV7g5VjGJ8hIDI2Cci3xQ3JeiZPe7PLu X-Received: by 2002:a17:906:8313:: with SMTP id j19mr7093886ejx.196.1571375041459; Thu, 17 Oct 2019 22:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375041; cv=none; d=google.com; s=arc-20160816; b=Cu3zbEvVfMMLoYyWd8yGQ4es+SGfNinnEuMAmlnU8x2/yXZ4Or5+0mRgekyaAGORX8 R2HQYOoMx6jOFimapLq6jjsqPNbhWT2ECGDDY2o0JWvWY415v+Pjug2oVYAraemf6fpM LF8NNDxGsmJ/9WR6RqSebj/vpStRqUaITrLS+dnxMziaXr7684NDI1hQZaL4kZAzmaVL xGwmtLZ3ZPKJm4QdZsl7+npPNv3qVVkRfSSzJuT8hXnn6UZv3wA19IS864Ba/FF4rnDh rXrGCNoent0N7BJwHVFidtqxRoHlWlsFd7hLCFol04IAkqcvTWSdQ9mAiV+LyWAxJNI5 VVYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ncsZKFuJ+Hs7vjW0mgbAMcSzYAJ7WnIsYxhkEcOusHY=; b=CM2/NqRajwqpqLY9Vq4HjVJeyvKdvKR45djfwVmAJSDRGvA9Fwag8lXP32bEj1in6x S3xJ9JY+wsLUu317RGui0sMbUHTHaPDZMPTljkPfnrkdDYnFqGj0ILeX3HnTbW8S0MHu xPRdrvU2wLbPeO9ToUQKDrqmW7GXV41jXSzTWzejmVucsERdr1G+iHzk50hrzs2Bh0HQ DXQvoxF9J2BbpxZi8cP3avePz+i47P+KTsDrOlKqukgEuwjEzDS5Hte02NhDjqRdaY4U /UCR61+WKuSLJFE9wWOLixv6maJ0a1yVnNyjDbwVqHYEGXKco5lMDCyjpWHeRIxw+T9U lI1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iTj3lkSr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m22si2525808ejr.368.2019.10.17.22.03.38; Thu, 17 Oct 2019 22:04:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iTj3lkSr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393868AbfJPWTA (ORCPT + 99 others); Wed, 16 Oct 2019 18:19:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:44032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390003AbfJPVyR (ORCPT ); Wed, 16 Oct 2019 17:54:17 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF1BE21A49; Wed, 16 Oct 2019 21:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262856; bh=x5Dh/lsFvWpy8PJRDAS+pIIwjaN0mNYgFOUG/aDqDhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iTj3lkSrcW05QxfqcyARYR777H3RRzENZBPcbiLU6KwqsLzCMa+Y+Wxx74kaEidMh /LVbCQkCIoQUdOSAq2uLhmvikNkCEPSYNb7gOtJrpnAOhb6OkeCjGoMKyrze4u6DO/ IPD/Z9QXEofG7U+rQci5R6z5bgSEsjRU2647C9ww= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , zhengbin , Miklos Szeredi , Sasha Levin Subject: [PATCH 4.9 23/92] fuse: fix memleak in cuse_channel_open Date: Wed, 16 Oct 2019 14:49:56 -0700 Message-Id: <20191016214819.229425478@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhengbin [ Upstream commit 9ad09b1976c562061636ff1e01bfc3a57aebe56b ] If cuse_send_init fails, need to fuse_conn_put cc->fc. cuse_channel_open->fuse_conn_init->refcount_set(&fc->count, 1) ->fuse_dev_alloc->fuse_conn_get ->fuse_dev_free->fuse_conn_put Fixes: cc080e9e9be1 ("fuse: introduce per-instance fuse_dev structure") Reported-by: Hulk Robot Signed-off-by: zhengbin Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/cuse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c index c5b6b71654893..d9aba97007267 100644 --- a/fs/fuse/cuse.c +++ b/fs/fuse/cuse.c @@ -513,6 +513,7 @@ static int cuse_channel_open(struct inode *inode, struct file *file) rc = cuse_send_init(cc); if (rc) { fuse_dev_free(fud); + fuse_conn_put(&cc->fc); return rc; } file->private_data = fud; -- 2.20.1