Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp234350ybg; Thu, 17 Oct 2019 22:05:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqwf7QarpTGjX3Cw9nd3H4RZnYyhsDK48PAH3LehPKeVSZJabkGByVfl+Fyze6AjgQU3gdpV X-Received: by 2002:a50:b5e3:: with SMTP id a90mr7428017ede.201.1571375137142; Thu, 17 Oct 2019 22:05:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375137; cv=none; d=google.com; s=arc-20160816; b=HqRx7AdduRkPziLzxqzYL75GFkanCmSx2A3BRFa0vMGngoCYAsWNljZ0yzBScQTDrc VMbN+Ltuzh0Ew13ZT3/EDuP6fodQ+Wt+Wd278O4Pw+z6BG9VgEtYA5snrfO6Q8DToIor nJHxKBCdB6vOaQnlamj6hW5mQ+TyBWTUlUxVcE4rKkM2WnWkss4lbZVEHIw+cjPQjJq1 2xuU/CPm/YmiKeR5Jfj8TOa/7W6eF24pptBMkNWIQE7YrLOTA1SnBPst9yHVXe63TzgU ByAKTbRFynQlB50HW5o7ax+cYb1L0x55iVrO2Epv2Rj4Rvb3nTdv5IDRift49bRV89m0 jjFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7//C7cGHqulud3wtDEJYBcYc2r6sY82wx9WOhLmoV2k=; b=zDejN2Ov4twPvJ/empl8N+haRogtRaWoV/iAgOasMfVnUK9NFHsWalvMKrVwXtBP4d rbDjwg69ewt8zOT45uNlkvek3yIJvkBWIyAyRa9LtdkITeKDuvjGu0LJfSLp8sMoOqtE jnsJgS2vS07U8eln8Cf71SUpFcdhUzp5i2COkvcUJdM2bzWPIirnzvtHbDlR5n+J82Px 4t4BKOTctOD6POAVTd+uNaH3OvtJTQJgQWtnMB/4CN7DAa2yW98kBt5YhmbbAvqqIItD r6PEyNSGCAacs0uohJ1WJlwE2TmKv/Xhvh/rKdAiFdqC7IFe1IcBCnfVLbIeP3KVyVvr K26Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CUzwGpNa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si2766741edq.163.2019.10.17.22.05.13; Thu, 17 Oct 2019 22:05:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CUzwGpNa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405540AbfJPWTo (ORCPT + 99 others); Wed, 16 Oct 2019 18:19:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:43514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437637AbfJPVyB (ORCPT ); Wed, 16 Oct 2019 17:54:01 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D179021925; Wed, 16 Oct 2019 21:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262841; bh=/nAysgjTFmewi/5K89zTSe8m+NSh6ZbHkmJVyj9QHAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CUzwGpNafoBJxs0QGOeA6MBjtpWH9Lr3e198myUhQDwOfMLJOunFbU02u2TDH5NhC y0TymvrWOKTsZuEJm5oBcv+m6T0VZRKda9W+lAblRYAl8HPpoy3/8rRLnuYg6odBzH Wuko88zUcEKCArLxLHb1nIW3u7biugMPtxKiD4eM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 46/79] USB: chaoskey: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:21 -0700 Message-Id: <20191016214808.032672151@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 93ddb1f56ae102f14f9e46a9a9c8017faa970003 upstream. The driver was accessing its struct usb_interface in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: 66e3e591891d ("usb: Add driver for Altus Metrum ChaosKey device (v2)") Cc: stable # 4.1 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/chaoskey.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/usb/misc/chaoskey.c +++ b/drivers/usb/misc/chaoskey.c @@ -96,6 +96,7 @@ static void chaoskey_free(struct chaoske usb_dbg(dev->interface, "free"); kfree(dev->name); kfree(dev->buf); + usb_put_intf(dev->interface); kfree(dev); } @@ -144,6 +145,8 @@ static int chaoskey_probe(struct usb_int if (dev == NULL) return -ENOMEM; + dev->interface = usb_get_intf(interface); + dev->buf = kmalloc(size, GFP_KERNEL); if (dev->buf == NULL) { @@ -169,8 +172,6 @@ static int chaoskey_probe(struct usb_int strcat(dev->name, udev->serial); } - dev->interface = interface; - dev->in_ep = in_ep; dev->size = size;