Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp234604ybg; Thu, 17 Oct 2019 22:05:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmd3Hlp58U4PmIadYS54S/vMJEnBdRT3wO3JN5E3OCuxCl2g9/CQ7vQLtfU8FdTuDgIih4 X-Received: by 2002:aa7:c259:: with SMTP id y25mr7485746edo.117.1571375153417; Thu, 17 Oct 2019 22:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375153; cv=none; d=google.com; s=arc-20160816; b=HGZu20uKQMR5dPRaeNA1qpqsxlRLdfcsHOqSNcdCZk5P+bGWltjgjoPs5jOEx9MJzP K8K/GiPduxzr9C2eRrBWlZyrvRyEkO/od3C4PK0ZA9hPHpUim7yX2ZBrG2/HQitLtiHc Ts8YO2Esirncr1w+P/UogZyDdvxxK5SEF3rLMSxm2PoRGNcrfA8ufo4EWHjQ3XiG+3gW 1kC7rbfLB+2pO6D+LsjGs3ZQiBEulvG5mM9JTE6ytr0rQCMBt6zarptKGQdSRgRBl3Bn 3tVHSwPRN5m87yOhFBdiGct+akKxYo4wSjNh2ayTqssXEjb73WT6KjD88pcG4SFTVjdF uvlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QilElAfNMIc5wzrYgiZNtzRIaA042KpLmGjJHNP0m4Y=; b=ppmXDltzZuzaQRvyMoqVLyeT1IyZO8ERqCS7K7IO6eOKeBSGDoNxYl93G1I/DUAoEE YotxHoy7CApNNoSfWa1fpXzgevIZBBd54rb7FmaiF++SMMUwbXHgm8METDoygoWH1HH+ h4eHV+Q7ildKmxzA0TPl+4d1MbqlPdwMKWXbLBJuef0/2JMqq17qGqkeHe620VVcAIyl GUFBKe9kqvbp9QTWfNzay7IC5eW1FUMS5+GHTKbN9UzufnHZFlvdzI9bomC7slRnCaB6 4TAOcZ5pXxnzgLKkrBqB5HfzzZsffcvjcTrlme6Tdk54CgN7H33Op+P7uckKqT/tdcUH C+ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aESJMlQY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si2901440eda.336.2019.10.17.22.05.30; Thu, 17 Oct 2019 22:05:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aESJMlQY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405735AbfJPWUL (ORCPT + 99 others); Wed, 16 Oct 2019 18:20:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:43232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394914AbfJPVxx (ORCPT ); Wed, 16 Oct 2019 17:53:53 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E806B21928; Wed, 16 Oct 2019 21:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262833; bh=vUuNRPi0giYYGTuJjTLfH79nTUgyyKJXjKsXqgR5Pg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aESJMlQYAs9uhbNenSr5CfBsbPgr/ogbmQEalr5qAy6ggpq7nL/rqZBtdv1jfz48P rJEGr3m5BUBWettEixMgs1VkYQZ+clZLOsiGYZaotTcLs6KDTCx4wPRYvxeeJDFzxw N7j0uHj6c7awzr9Rxr/avclT3ryON6Unr/eztBLI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab , Johan Hovold Subject: [PATCH 4.4 76/79] media: stkwebcam: fix runtime PM after driver unbind Date: Wed, 16 Oct 2019 14:50:51 -0700 Message-Id: <20191016214833.510973225@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 30045f2174aab7fb4db7a9cf902d0aa6c75856a7 upstream. Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface. Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device. Note that runtime PM has never actually been enabled for this driver since the support_autosuspend flag in its usb_driver struct is not set. Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") Cc: stable Acked-by: Mauro Carvalho Chehab Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191001084908.2003-5-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/stkwebcam/stk-webcam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/media/usb/stkwebcam/stk-webcam.c +++ b/drivers/media/usb/stkwebcam/stk-webcam.c @@ -642,8 +642,7 @@ static int v4l_stk_release(struct file * dev->owner = NULL; } - if (is_present(dev)) - usb_autopm_put_interface(dev->interface); + usb_autopm_put_interface(dev->interface); mutex_unlock(&dev->lock); return v4l2_fh_release(fp); }