Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp234925ybg; Thu, 17 Oct 2019 22:06:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwe6QILuOi8rbmIFUpXW16HYOZnUrOtx5oamcBURxVYJc2sopBezmrH+xeokd8DJp5szuTj X-Received: by 2002:a17:906:80c1:: with SMTP id a1mr6984303ejx.37.1571375177838; Thu, 17 Oct 2019 22:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375177; cv=none; d=google.com; s=arc-20160816; b=qaJzXBZQZLuaI10Lq131qFIUhamyswuX4cA2MMsUkgGmyx5jwIwKjxrM2pF1lxWF33 R7G3ZbeSs0lA84KUNdeg3fw3jYRo1SEqQAbDUpQIc0n1SG8jqYCB2ETsIIWdzB2qDT0A ojca7avkZsIEU1whDP6TVee1F/0v2SltuHvP4/geHYqAqw8wS8TNmABcMeJCWGmvUBJX Cxt5znJTLGI2EgjCJLw0QZMuPbNy/7kUPLNQOrgwU+ty9KaeiHHF4sYKzpZxdiBX4f5W 4JF/6YjD7lO2a0vkV7xyeo0SQ9G5IQ26N1M3fSrVlYs+MVgbdJavMVP0YMTwlgYha5aK vB8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/kj/RAMzfjacuiYH1rgw374aXkY6l3cMRgM319PFvmQ=; b=jlKvHGqey9ZdvDJrBOF16r8dnfjn9sjByVpuAE0/8FNst2m7y1oggva2GQN61TpLlV YkgFxvZZVTYH/pLVW3cKRA0a4hycgeVvuzNzS5pGLF8tsOfnP3fUl7v5QPOv0CFsDe2Z Tl7I6nZE0HA3ZkGcR5tSRNf4D/v7+ffP32WEuJktuaxmfCw6eVQZXHC0R9/77sz8kph6 Ala5135uhlZWYmNgKiJjPdHKXsZdL+FQYjsYDM3otw4OX5M3x1paRxrm7ngt/nH91yY7 X6YGbVRjryeLrwXsOP54FJ6xDB60C2rFriPZDIaUhUJUpiu3a+y0V6An+RUiu8jsf6Ei PlOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k62JdYJK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f26si2812815eji.55.2019.10.17.22.05.54; Thu, 17 Oct 2019 22:06:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k62JdYJK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407516AbfJPWUt (ORCPT + 99 others); Wed, 16 Oct 2019 18:20:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:42880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437526AbfJPVxn (ORCPT ); Wed, 16 Oct 2019 17:53:43 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34F86222C1; Wed, 16 Oct 2019 21:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262822; bh=hyhmoGrtgBALpuITUMJpgc5B0vB0P4Ck+P3tweLPDA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k62JdYJK+su9q3UteH5yyBCMJ/AFenNw4SDxApbLzsl9hvw58SQna7ts4ELagThA8 dOfLbRek5fnywcGQ0cHD9MMCbHbExrG9vBG8w5BnSdZkB+DMx0kZkdFhxVX7Gi+ELr ydBAC7YV8E1bKfK4KqzpdM4KmOpjGvpCfI8+5Cxg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marco Felsch , Alexandru Ardelean , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 4.4 65/79] iio: adc: ad799x: fix probe error handling Date: Wed, 16 Oct 2019 14:50:40 -0700 Message-Id: <20191016214826.468391956@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marco Felsch commit c62dd44901cfff12acc5792bf3d2dec20bcaf392 upstream. Since commit 0f7ddcc1bff1 ("iio:adc:ad799x: Write default config on probe and reset alert status on probe") the error path is wrong since it leaves the vref regulator on. Fix this by disabling both regulators. Fixes: 0f7ddcc1bff1 ("iio:adc:ad799x: Write default config on probe and reset alert status on probe") Signed-off-by: Marco Felsch Reviewed-by: Alexandru Ardelean Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ad799x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -822,10 +822,10 @@ static int ad799x_probe(struct i2c_clien ret = ad799x_write_config(st, st->chip_config->default_config); if (ret < 0) - goto error_disable_reg; + goto error_disable_vref; ret = ad799x_read_config(st); if (ret < 0) - goto error_disable_reg; + goto error_disable_vref; st->config = ret; ret = iio_triggered_buffer_setup(indio_dev, NULL,