Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp234959ybg; Thu, 17 Oct 2019 22:06:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcIUL2hkZ/5fP/91yHYs3jkpPAyrje+aixiPkNPhkSB6usc6sPhpGFWDSenEhYgGZsVAcB X-Received: by 2002:a17:906:9aa:: with SMTP id q10mr6740402eje.93.1571375180068; Thu, 17 Oct 2019 22:06:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375180; cv=none; d=google.com; s=arc-20160816; b=FV5UhhIPZLeCLvGvy1J2RYCtaz7jJo4jrw7KKRAJkBCLeWjkaufycMGyXQkYOcyR5b 3+lAW+CZdAz189dAaqzfAOPisANtbaq1gPJKXLfQGOhH9xujHcsEcs/XXIJmXH7jzCFL Z12L7D/1F1bSrGeX3WHkAc4jhwl5eiMefhsZZiiCcKSA2LTi/LzFghKNRXeYcuFCFOSj alJCIiEf2nJH8ulQDg+4Elxh7HsstezeuYp4J/589IWVE/Ang8KnkApLlc22W9uWJc0g FxWTtO+mwVsJxUzRx6KDzT+CNniXFo0T8C8mzspgNZouirgWBiomR10ydKOB+G0CStMR FcwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=S/8zAUVmmaG3hA38YNPPL2fBGJ7XPf9DLrN4OgtWYQ4=; b=IliDsUnyxLnKDO5YQHEXJxfLu19/fA0M/7yrd2/zHd1wzMiL2umsdfsBkZhbDRQRz9 CjMcOIu/5M0BNwPEhcv6nU/X8KHzarqoaAtZ4aEFU34nzvVwnKygvdUO1GgCKotvUJxt wJ6elb0eNexoIox3bUUNnBKnF6w10jnAjy9bW7E/NMukph8YDVZvr0snyyJAeTey3Nmi c+ny5pPW736GxxlFaqWGxEdIgwc+IwztaJLoQWnCXnXy/KvMQzoxzUzZ8F2JeYQL/149 UMofSGxqFsr2gPjao571DbdbsGpeVZKWZC2DzOL5UcleHj86ADx2SoN75CckA29R6Kn0 Djpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VXynawIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15si2682035ejx.56.2019.10.17.22.05.56; Thu, 17 Oct 2019 22:06:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VXynawIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407528AbfJPWUy (ORCPT + 99 others); Wed, 16 Oct 2019 18:20:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:42784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437568AbfJPVxl (ORCPT ); Wed, 16 Oct 2019 17:53:41 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D2E721D7C; Wed, 16 Oct 2019 21:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262820; bh=heFOay0TYzWjNvKYNEz8ViFfCH3YlYJUtQpL2khwNhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VXynawIR6D/yYgF8iKRO6lECNPExK9Mj66E38pVcUVCweVTvEcr3IdJRSTnpgeA6b DXePGmo98OsSQQGS9RuglkzX/8xPcbGZU1KfJcHEjB/0veETIZRfRKn/Ipk7tCnD4y 45Y+KOrkmX7B6w/ADCiHL5qICbkoutVKSBmCrjSU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 63/79] USB: legousbtower: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:38 -0700 Message-Id: <20191016214825.045855955@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 726b55d0e22ca72c69c947af87785c830289ddbc upstream. The driver was accessing its struct usb_device in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: fef526cae700 ("USB: legousbtower: remove custom debug macro") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-5-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -302,6 +302,7 @@ static inline void tower_delete (struct kfree (dev->read_buffer); kfree (dev->interrupt_in_buffer); kfree (dev->interrupt_out_buffer); + usb_put_dev(dev->udev); kfree (dev); } @@ -820,7 +821,7 @@ static int tower_probe (struct usb_inter mutex_init(&dev->lock); - dev->udev = udev; + dev->udev = usb_get_dev(udev); dev->open_count = 0; dev->disconnected = 0;