Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp235043ybg; Thu, 17 Oct 2019 22:06:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQPF3N4FuTJdctUrrbYJW8Vm09X8u75sn5RSO1upzQXOdOAsLWc8nYlwsiHXMQZPmBS5VR X-Received: by 2002:a50:9f68:: with SMTP id b95mr7524286edf.301.1571375185871; Thu, 17 Oct 2019 22:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375185; cv=none; d=google.com; s=arc-20160816; b=YcaSiAdTRJSJtULKGTCh+4IlHDpOMZzNMRGpUrXyjo9iyKHrnFL3Vnt9ReLuSQOFRW Oqt3m2VLH7PspOeq/7JJ/nuZa/CloIbMu4n5tDWvCdx00nblMmnEeR9v4w8v5AMZknbE 0JY1vzgdQLAyRIRe+yknGvPef71NIOEHzYcB0ORYWucn4tzHgzKhxD+ni28sfJPMpnwf z9BZNdBqEFEuOiK9mkmxUg3vvOKp24GRBHm9Du0E8AlJlb8nmVBT6YoDZElL6K87ZZwB cGXxxifdMqwnrY6Rq/sqJ7hboikZi95WGaTH7GfkajmZfLoPBM4qQ8mIBeGsd8u9paCl s20w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bYGgWG+Aw6iiWQ9BtnUzGRQTiEUvrWEng7AqtCTXZIo=; b=VEXKH/aw9SUCaA8i7LTNMhjNlcrcN1U6iy3Wctlpo/McHCLATJeyJTL2//EnYrzljj eZOidNmCTYPM67ALg6Mji+XY0lHHhw71bWGui2eMGiqfODE1TT/JTDPTmpF7LskEcn+P XR04fzA4Ozn6RJn3TReujWuxf31SGKyiMesAKylY+TM/mxgzk3ml3RxiJbijLNQNhNXZ B+yUhEhrNXhI0oHgpBV6ZAvdANJWuT30HzH0ZhcBJDTuqmbeqtFrTwHhNuv+uGFLgoYT JNibNr9WpOUgx8rENAPy1kDo0UlEBLgodYivQHfx6y316JYKCNb8t/MvBUDdvCy4JufP VYDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=how330wB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si3116270edg.339.2019.10.17.22.06.01; Thu, 17 Oct 2019 22:06:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=how330wB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407539AbfJPWU4 (ORCPT + 99 others); Wed, 16 Oct 2019 18:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:42802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394883AbfJPVxl (ORCPT ); Wed, 16 Oct 2019 17:53:41 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D0D921D7F; Wed, 16 Oct 2019 21:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262821; bh=+WHMJPY9Vs1h+DK/XD29qKX+c1rTvE9yIux+6B5TVKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=how330wB5fePDUzojtC3FW5aVCwv9yJ/9T7Mwyv2C3YEjyLC1DVzDHkX7oNgYdmnX 92+mY58/hYHvXfar6t5gGNe2zcXwxvlwKCtm82eDiH7ChcYUwLtKWn2EjVdZvnRqlT RHjRLzQLW0ko0WnJbLA+6soKGlbKSsG3jaX2hWzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost Subject: [PATCH 4.4 64/79] staging: vt6655: Fix memory leak in vt6655_probe Date: Wed, 16 Oct 2019 14:50:39 -0700 Message-Id: <20191016214825.771120699@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit 80b15db5e1e9c3300de299b2d43d1aafb593e6ac upstream. In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost Cc: stable Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/device_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1668,8 +1668,10 @@ vt6655_probe(struct pci_dev *pcid, const priv->hw->max_signal = 100; - if (vnt_init(priv)) + if (vnt_init(priv)) { + device_free_info(priv); return -ENODEV; + } device_print_info(priv); pci_set_drvdata(pcid, priv);