Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp235353ybg; Thu, 17 Oct 2019 22:06:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoyuaxLZCEys20ZMfE2YNDvIB3QAD0VjUnSpQ8HpxvJkaoE1hlcntSw+G8NH7tI1Hebw7p X-Received: by 2002:aa7:c38f:: with SMTP id k15mr7840299edq.100.1571375210117; Thu, 17 Oct 2019 22:06:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375210; cv=none; d=google.com; s=arc-20160816; b=fd27Z39klU4npVdXgYJ8H9XlmFxWuD9k0Y7HWizPa6fEEjw45qwv6mPp2cNCTTJ6gk HEAnKqjSHrwtJP0UYmRhs+82AfiznFinVGEVv4rV10Dy+oH+V9e4UKA6ZE86iVIgWvw6 u/YQ0rv99BzzzJ+WBLx+qTUgUfctrtOMpkAuKF4jW5pNl+EcsBIHb0QIEINbZDNAsoJt ZZvalSOmtf8LR1yjf9GRo8REOnkB8X3WIdPN0+/MSh+reNYeLkaIi/yRikaTdgb5/vNy Jbiv/oTRyPpQ/VuzzcaUCMgKLTGldQxWJAKs+9Vlj9JzJaI1fh3yuIGVNvsgqhGTz+zr Bqvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RZr7kVynSnyuEGNMp+aZlD+o9rFJwTiwMAy8qHlgFMw=; b=y+OoYpGZ4+lYxAKkq+kwxHXiib09HOBUiwvn1LZQ4Ji1wXrCpE9bc6Al5/ECwsbhDG ZIUGz9BInAjpVczDUgUce7Dv2H6+dT4i4x4N5HzOsQRhOFOBFjI0QC3k7LNC/gNtEWyz Qjjm2R4okxUuMM64abZXiHQ/fiKarx4kNNCBB1k9NBPVSi0xvWFdaOP3XUC3Pz1vT0E8 5YwLZoj0Qt6uO6NeKOuX45B0qq1QCUw18NsIS0WwQjgVIc5XlX6Rqm68gtSumWp22xVM 1ZoRjYEWFsyA5JlNjAaFuIPGDcYDWxNJ5KokxSpGtAcMeQxyXzxIqg4/RQe5/Hk0Lho0 nqGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M0sm3KFd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e23si2914176edq.344.2019.10.17.22.06.26; Thu, 17 Oct 2019 22:06:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M0sm3KFd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437522AbfJPWVi (ORCPT + 99 others); Wed, 16 Oct 2019 18:21:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:42480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437519AbfJPVxb (ORCPT ); Wed, 16 Oct 2019 17:53:31 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8D58218DE; Wed, 16 Oct 2019 21:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262811; bh=uySbU/iStrpg7gYqVAO/jw0Lt6eyVT6b5EdH9JhGSaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M0sm3KFdba4kkdnvyNjF094b2e85wVN/DFgvfrUweu4KU2qMDmMk2NOlY44xmMnrR Q0uprTzHSGWE/l7WMrFmiKzbzO6CMQkni69KzUlgAGjE1zgTNKG9LBrJwujcN5fFQb VHxQTfhcLUtJ6dAiI63M0KZJUZri5Ni+1vKNxOh0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 53/79] USB: serial: fix runtime PM after driver unbind Date: Wed, 16 Oct 2019 14:50:28 -0700 Message-Id: <20191016214815.695735575@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit d51bdb93ca7e71d7fb30a572c7b47ed0194bf3fe upstream. Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface. Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device. Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191001084908.2003-4-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/usb-serial.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -314,10 +314,7 @@ static void serial_cleanup(struct tty_st serial = port->serial; owner = serial->type->driver.owner; - mutex_lock(&serial->disc_mutex); - if (!serial->disconnected) - usb_autopm_put_interface(serial->interface); - mutex_unlock(&serial->disc_mutex); + usb_autopm_put_interface(serial->interface); usb_serial_put(serial); module_put(owner);