Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp235622ybg; Thu, 17 Oct 2019 22:07:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3Xe3k8aPwprZ3/om/uv+wAO+cWRV3JOWLSy88N8W6/4hGX+Hyn8BJAtEgKWftqNsudPGQ X-Received: by 2002:a17:906:8313:: with SMTP id j19mr7102622ejx.196.1571375229585; Thu, 17 Oct 2019 22:07:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375229; cv=none; d=google.com; s=arc-20160816; b=0Ok8/5AgpwfQIqfQOxvLQV1PmqqJynJW6kVs9SOWs7n6jQ2zStReYhMu89zl8Uet7N Y7XwZTjuW84YsASEiwWZmUQHqcvTmIesMidIQD5LCOL3uh7TsGHNU3QQQ1WbJEWswFu3 6sRWVxP2nT1mri1OqgedK60L4qUgB239VnZRqOVsC678gCDpeCs+BZZWR3YnnA5ZnUUb g2GN1iCccP6KILLdwSSidvCCCj+iTACB2u2gZhPWtACDw75JPDm/wdEY+EcC/GmSOjom LQVfgBpruSxKHeE6Fv9W1llxtcXRwOEFjy7F+atvyGL1uRmBpMmAiM5lpNGeUOAeMZ8k +81g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PET+szX/l1miPM0ZKXbW4uOmFcm6QF3AnL9P1Im2eJ0=; b=ct3KAowX0ifwhUvhvrENPthrZc8O4bH/F2G0tQ2ondQx5gt/yfAtOiEeTepcRbYWWe 5lbpgIUYagKqbJFr7rckCyQNDs7lk3RANb8vXt3/OgqG4fNyuR6yx11+uzLVrzwHkofr edsR4hzv+BJUxKoKzGNJgcYl2W6vfhHdowpc3bgucTnhWIcgMgYjYZmOxjUR/YUQ7lnK Aktf/L77efzYeGiyIAyQ7cC8rHgsJGmENxRGlspBJ12BAW6nHrSB8c91SsS1/fE/j+H+ 1e10oFyM3jiBE06v2/i8c09cgyuuG2jdgJrozFAtKqQWwMfF/3E0zUjjuNn/HQXmjqkC L4ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ct0MhTd0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r19si2839392eji.376.2019.10.17.22.06.46; Thu, 17 Oct 2019 22:07:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ct0MhTd0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407608AbfJPWWH (ORCPT + 99 others); Wed, 16 Oct 2019 18:22:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:42204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729185AbfJPVxY (ORCPT ); Wed, 16 Oct 2019 17:53:24 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 651D321A49; Wed, 16 Oct 2019 21:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262803; bh=ym8G2ZdQbDsO+1BvbPg5YIeTwSU9bt9Wg46NbwfNwBo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ct0MhTd0KW5fKw8gejZaojr0TI80SXIROvUVW/QKT2aysnRtD0KE7WxEVy1bzm4Aq u7VPLzZ+w+NW+pwioqC1eeU37FK2PoNjpM6OnQ4w7jeUKoSSahpjc1HGTVtIGDph8W C9ukt6wQT70M3Jh3Ro0DmI8t4/xBCaY2To+pA+hY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Sverdlin , Herbert Xu Subject: [PATCH 4.4 09/79] crypto: qat - Silence smp_processor_id() warning Date: Wed, 16 Oct 2019 14:49:44 -0700 Message-Id: <20191016214738.404173114@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Sverdlin commit 1b82feb6c5e1996513d0fb0bbb475417088b4954 upstream. It seems that smp_processor_id() is only used for a best-effort load-balancing, refer to qat_crypto_get_instance_node(). It's not feasible to disable preemption for the duration of the crypto requests. Therefore, just silence the warning. This commit is similar to e7a9b05ca4 ("crypto: cavium - Fix smp_processor_id() warnings"). Silences the following splat: BUG: using smp_processor_id() in preemptible [00000000] code: cryptomgr_test/2904 caller is qat_alg_ablkcipher_setkey+0x300/0x4a0 [intel_qat] CPU: 1 PID: 2904 Comm: cryptomgr_test Tainted: P O 4.14.69 #1 ... Call Trace: dump_stack+0x5f/0x86 check_preemption_disabled+0xd3/0xe0 qat_alg_ablkcipher_setkey+0x300/0x4a0 [intel_qat] skcipher_setkey_ablkcipher+0x2b/0x40 __test_skcipher+0x1f3/0xb20 ? cpumask_next_and+0x26/0x40 ? find_busiest_group+0x10e/0x9d0 ? preempt_count_add+0x49/0xa0 ? try_module_get+0x61/0xf0 ? crypto_mod_get+0x15/0x30 ? __kmalloc+0x1df/0x1f0 ? __crypto_alloc_tfm+0x116/0x180 ? crypto_skcipher_init_tfm+0xa6/0x180 ? crypto_create_tfm+0x4b/0xf0 test_skcipher+0x21/0xa0 alg_test_skcipher+0x3f/0xa0 alg_test.part.6+0x126/0x2a0 ? finish_task_switch+0x21b/0x260 ? __schedule+0x1e9/0x800 ? __wake_up_common+0x8d/0x140 cryptomgr_test+0x40/0x50 kthread+0xff/0x130 ? cryptomgr_notify+0x540/0x540 ? kthread_create_on_node+0x70/0x70 ret_from_fork+0x24/0x50 Fixes: ed8ccaef52 ("crypto: qat - Add support for SRIOV") Cc: stable@vger.kernel.org Signed-off-by: Alexander Sverdlin Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/qat/qat_common/adf_common_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/qat/qat_common/adf_common_drv.h +++ b/drivers/crypto/qat/qat_common/adf_common_drv.h @@ -95,7 +95,7 @@ struct service_hndl { static inline int get_current_node(void) { - return topology_physical_package_id(smp_processor_id()); + return topology_physical_package_id(raw_smp_processor_id()); } int adf_service_register(struct service_hndl *service);