Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp235914ybg; Thu, 17 Oct 2019 22:07:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUHpEZ2dBe0fzoFB2otmZ90shiYcedw4OhpmoOxMelH7uf2w+LrKW9tmNK10CllskjrSTL X-Received: by 2002:a50:ef17:: with SMTP id m23mr7513417eds.200.1571375247328; Thu, 17 Oct 2019 22:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375247; cv=none; d=google.com; s=arc-20160816; b=nxIX0xzHggkr4Fytpp9wfE4YaSRjHKhdQ2F4g7anv6QLN9/r1ymddBntCyqKqkH8gV 6Yt/y8gmWphQTXHZ6YH9nduAyRfHkTHH4Dfh1Bq9SgTzvNXBANxZrwzyHBJ+fB0dUqdQ KJaFsyXeXl1NIwsxqAu5CRN8g7orlE/ccslSPOBuQpoGfl2aAO07+s8SnNNQggo7tzRs qxYaLA8ghru9Mj5mtArRPA5iIRQu621P1UfreKmEe63dkYsqkXQr/ZiiO52RkNMbbc9O CK1U8lj/BlGEHQ6MA2pciA6Tp9LPqhokwya5q5DOqOni2QgaaGHUsoEvcrFRjl8+omcF b4RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5SQCmBBQRIarirRFkaCsu82KYUYBZif8eGHBeN/ov+k=; b=zB3iKj91kpRmzh7gEZWkeQs3yd9HdaW4o5mcXTNGvObIcaMkNAcyHrZQZ6ERPkt7vy 9QdChDbK2u7ZV9uC3QujT2MdjsKEc7ZjHJWO2i2S93Yap5NiwJDUWOHDcRFtgrXKp5Gn iREIddYbDodJSba0JgKS/1XTHvErGXPaCwVNBdgP96INH617VmzdMHhHC1a1ifklTZ3I IqPQmsL0dTs5H0X2ly8ZTC6/Oreub3FO2g2oc46XZucJYijlE/0V5BnNPNmHGND81Dg2 +KymcEQzNSkqLN2Q6Mjk4Tzu/Bs7iLZ3G2lBkf+x2tSTEUPdil1Ba8H6sIdDeBfjC9/A 1OiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Kl6LcHyi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si2704813ejr.296.2019.10.17.22.07.04; Thu, 17 Oct 2019 22:07:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Kl6LcHyi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407661AbfJPWWr (ORCPT + 99 others); Wed, 16 Oct 2019 18:22:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437258AbfJPVxK (ORCPT ); Wed, 16 Oct 2019 17:53:10 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70FA021D7A; Wed, 16 Oct 2019 21:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262789; bh=OrPEpdqwd733jdhoGK9h+vv1s9G3mOo9wyJbXWHjDiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kl6LcHyiIgz8eLctXwINHVmPZOMsqcoY2W4EV85ScZSctQ9fzF3tkI+JMsUh3XBqw LzEuLEwkoIkr846VRCuls+mQSvtuEbMTBaPMMK7GGShYtHPHARNBUB/7ztLus+PdNq pTJhZOpK533MjdWSTv6no2cq5ekVDxxd78swK0SM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sebastian Ott , Vasily Gorbik Subject: [PATCH 4.4 03/79] s390/cio: avoid calling strlen on null pointer Date: Wed, 16 Oct 2019 14:49:38 -0700 Message-Id: <20191016214732.783408279@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Gorbik commit ea298e6ee8b34b3ed4366be7eb799d0650ebe555 upstream. Fix the following kasan finding: BUG: KASAN: global-out-of-bounds in ccwgroup_create_dev+0x850/0x1140 Read of size 1 at addr 0000000000000000 by task systemd-udevd.r/561 CPU: 30 PID: 561 Comm: systemd-udevd.r Tainted: G B Hardware name: IBM 3906 M04 704 (LPAR) Call Trace: ([<0000000231b3db7e>] show_stack+0x14e/0x1a8) [<0000000233826410>] dump_stack+0x1d0/0x218 [<000000023216fac4>] print_address_description+0x64/0x380 [<000000023216f5a8>] __kasan_report+0x138/0x168 [<00000002331b8378>] ccwgroup_create_dev+0x850/0x1140 [<00000002332b618a>] group_store+0x3a/0x50 [<00000002323ac706>] kernfs_fop_write+0x246/0x3b8 [<00000002321d409a>] vfs_write+0x132/0x450 [<00000002321d47da>] ksys_write+0x122/0x208 [<0000000233877102>] system_call+0x2a6/0x2c8 Triggered by: openat(AT_FDCWD, "/sys/bus/ccwgroup/drivers/qeth/group", O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0666) = 16 write(16, "0.0.bd00,0.0.bd01,0.0.bd02", 26) = 26 The problem is that __get_next_id in ccwgroup_create_dev might set "buf" buffer pointer to NULL and explicit check for that is required. Cc: stable@vger.kernel.org Reviewed-by: Sebastian Ott Signed-off-by: Vasily Gorbik Signed-off-by: Greg Kroah-Hartman --- drivers/s390/cio/ccwgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/s390/cio/ccwgroup.c +++ b/drivers/s390/cio/ccwgroup.c @@ -369,7 +369,7 @@ int ccwgroup_create_dev(struct device *p goto error; } /* Check for trailing stuff. */ - if (i == num_devices && strlen(buf) > 0) { + if (i == num_devices && buf && strlen(buf) > 0) { rc = -EINVAL; goto error; }