Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp236163ybg; Thu, 17 Oct 2019 22:07:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUHASAqngxHkhWps403aBhagSRc6XK1cTQWnh5KO4koF9XyepRKAaP8QzefnJ1s90zpPY0 X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr7678669edr.279.1571375264176; Thu, 17 Oct 2019 22:07:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375264; cv=none; d=google.com; s=arc-20160816; b=mif3hT0gJVQrN2aLl5MUoTVz5zg2jBc/lXrG/eHoAJbGJDvvWr0/UhNt4X4Lz2TQyU p/ylkZZiVCnn6RxmbZzX/10YNg2bvcR8A6KYvxeneQu2r7zr4PChTb2chRwB6gY5bGob gkVk8aM+dtRrWa3WkMBRGw1LX0JyhsMwXI31osA8ISZifopJZsR/RZwa5TQwXyxv+Es4 nm6t+EUq4zEtaINFoM/zDCvYl05TU8Bb99rhm/B8WzJyS//2XV4fHyIM1kFC9w4yZfDb xWK9Tua/3FQ6qd/KYR/gf1GnHr9PUNmCNUB2hk2WeRzR6fQccpKAFz6BgPTJTf5v3YqD Mb4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wyYPBkshmJkMPoZ9DOW9ZEpVYue0pVbeL579d71H8ao=; b=A+veeSEfNDV0FfsVGtUGSlFYnVRZShsaiZT+AghYPMiyawPqezozc5qya2USPcVDRu IKn7XFAzrwLxBctnIyeuDDUX8lJHDg+Dd1E1U5+ncYlttNzyQ0rAMNXQauQUgn/5fX6E Ln2QL/pLCq5yczLfCmekzFkRICcza+ltzABAevO2pNeJYnwgIxMx93h94coKGOrFbKCd 7EnYp2xhODLqAn0XPmP8FGWjC8MMlzRReJCE9VOENty4TrLryCznPcGLmJ+wqFqxIyv4 OQqKoNhfVhL93hdtkZIioDrDRv9aD5paKzaj6EcIcCGn+I0GRBXaeqO8evbJQ+kN+SF+ iy6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=X+rnxRfu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si3447020edb.324.2019.10.17.22.07.21; Thu, 17 Oct 2019 22:07:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=X+rnxRfu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439408AbfJPWXQ (ORCPT + 99 others); Wed, 16 Oct 2019 18:23:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437114AbfJPVw7 (ORCPT ); Wed, 16 Oct 2019 17:52:59 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1D4621D7C; Wed, 16 Oct 2019 21:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262779; bh=55pIYmCZVMIoqRNbdhjyORr7+NR7SE8xoBV2E7ain4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X+rnxRfu+MmPEofIN+Mqa7lsvp1PANV52EzjkL9G9WlZLFB3fwYY26zPZiASCohxF Uaj7rIDdiUk2s4RKhi+FPL+A1N/0+B47oBrZsR0/+BtiBe4ZEkiGrdHFGv4P3VwmEE 9I/jIiAdI/2F5Zv6KiWHN6Y4Qx3T6YH9U9HbRhqo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heiko Carstens , Vasily Gorbik Subject: [PATCH 4.4 02/79] s390/topology: avoid firing events before kobjs are created Date: Wed, 16 Oct 2019 14:49:37 -0700 Message-Id: <20191016214732.696445726@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Gorbik commit f3122a79a1b0a113d3aea748e0ec26f2cb2889de upstream. arch_update_cpu_topology is first called from: kernel_init_freeable->sched_init_smp->sched_init_domains even before cpus has been registered in: kernel_init_freeable->do_one_initcall->s390_smp_init Do not trigger kobject_uevent change events until cpu devices are actually created. Fixes the following kasan findings: BUG: KASAN: global-out-of-bounds in kobject_uevent_env+0xb40/0xee0 Read of size 8 at addr 0000000000000020 by task swapper/0/1 BUG: KASAN: global-out-of-bounds in kobject_uevent_env+0xb36/0xee0 Read of size 8 at addr 0000000000000018 by task swapper/0/1 CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B Hardware name: IBM 3906 M04 704 (LPAR) Call Trace: ([<0000000143c6db7e>] show_stack+0x14e/0x1a8) [<0000000145956498>] dump_stack+0x1d0/0x218 [<000000014429fb4c>] print_address_description+0x64/0x380 [<000000014429f630>] __kasan_report+0x138/0x168 [<0000000145960b96>] kobject_uevent_env+0xb36/0xee0 [<0000000143c7c47c>] arch_update_cpu_topology+0x104/0x108 [<0000000143df9e22>] sched_init_domains+0x62/0xe8 [<000000014644c94a>] sched_init_smp+0x3a/0xc0 [<0000000146433a20>] kernel_init_freeable+0x558/0x958 [<000000014599002a>] kernel_init+0x22/0x160 [<00000001459a71d4>] ret_from_fork+0x28/0x30 [<00000001459a71dc>] kernel_thread_starter+0x0/0x10 Cc: stable@vger.kernel.org Reviewed-by: Heiko Carstens Signed-off-by: Vasily Gorbik Signed-off-by: Greg Kroah-Hartman --- arch/s390/kernel/topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/s390/kernel/topology.c +++ b/arch/s390/kernel/topology.c @@ -291,7 +291,8 @@ int arch_update_cpu_topology(void) topology_update_polarization_simple(); for_each_online_cpu(cpu) { dev = get_cpu_device(cpu); - kobject_uevent(&dev->kobj, KOBJ_CHANGE); + if (dev) + kobject_uevent(&dev->kobj, KOBJ_CHANGE); } return rc; }