Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp236501ybg; Thu, 17 Oct 2019 22:08:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMdZs8Mtfa86IklF7Qle/GRELlGvpXrIDpjlhgEPjLDQDYRXRIxoLLzi+xoJ2TyJWlIRkG X-Received: by 2002:a50:ee8f:: with SMTP id f15mr7648006edr.127.1571375287339; Thu, 17 Oct 2019 22:08:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375287; cv=none; d=google.com; s=arc-20160816; b=RcC6BNBQtHpYzhSx5OkOI8/Kl3ZOK8UI5Y5Kg7toIueqCAtGOPG+K16tjjHkSrKD0x N+NO+QvniKpGA2WSfTwHYQmiOseQxD3kcKJPUtZpCpMYGVzfS622BHx7QYufgj/s4GT3 gdpa/CLYhXB2V5TkMdNmHUovSnKsydO3zajj0ylI5dSgDVB30MeOZKidmpIAPNOG9y23 SzpXPl6lIwIxhWX1SJVrIbBLiofSjgfIxJ3YRMp2BiC2EdiMJ/ifBbbbL+Y3r92olRAp CRFVZBSePBiDmZ6x2NSAsHr55JbMEOhUuxLpOVme259O+p2JwhxNmwNh4TO9mxkA42D0 +CBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9NSLM6M0rbkro//uwakrKl8dJc8eszFhd5DnheN+mlE=; b=vB5HX/KQjeMFePylMwF6phP1QcwY2MFZ497MxxUTXjHtWTTHC6kQ5u5c9qqrDUXAXA ZXTKP/NhMS07CzW7IspaMA+cTb1HHtrutkV5AP29s4Lw+WZpwHKGGmKaaYYaXawxvWR1 +dKsfZPqGPgSYWNJ8wVcgBEVRHSpJm3yDBKZ7H4mLIx5UBhhWj0ebLH3cHZSRS71E1lR 2EE0DpXyvztqDdtyf+h4zvJP/XnV8vW4erjv964h62Odt8gzyUcLTdD25cNpVTIS9eKu ek7tFawrluVfm7XkpizgSGHUOQtuHcQVL0K2uMjDDeqhD6YQoA6L6gotrEabx+xTdoiV kAnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ag92/JOG"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f33si3221535edb.281.2019.10.17.22.07.44; Thu, 17 Oct 2019 22:08:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ag92/JOG"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439400AbfJPWV7 (ORCPT + 99 others); Wed, 16 Oct 2019 18:21:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:42306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394858AbfJPVx0 (ORCPT ); Wed, 16 Oct 2019 17:53:26 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30F7721925; Wed, 16 Oct 2019 21:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262806; bh=Bf+ER69cBxaSgSskm14ZAD6nSzKcf7naYP/B+3ZIYU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ag92/JOGMWolXSIdPiD8z0PbLPAcMoVj3Ep7ofrlQLA7BbrQ+EGsNFwxjTGSj7KKw 4WbLElfyhXTVxGs6AVi6AAeRR+SvaMhL7xLVpgz690iHOgBXmLtDJFifrQe33y1SEc OM6bZUp4LV9jf73xnzS9DHaYZfGnYNyva+7KNaaY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , Peter Korsgaard Subject: [PATCH 4.4 48/79] serial: uartlite: fix exit path null pointer Date: Wed, 16 Oct 2019 14:50:23 -0700 Message-Id: <20191016214811.705472460@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap commit a553add0846f355a28ed4e81134012e4a1e280c2 upstream. Call uart_unregister_driver() conditionally instead of unconditionally, only if it has been previously registered. This uses driver.state, just as the sh-sci.c driver does. Fixes this null pointer dereference in tty_unregister_driver(), since the 'driver' argument is null: general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:tty_unregister_driver+0x25/0x1d0 Fixes: 238b8721a554 ("[PATCH] serial uartlite driver") Signed-off-by: Randy Dunlap Cc: stable Cc: Peter Korsgaard Link: https://lore.kernel.org/r/9c8e6581-6fcc-a595-0897-4d90f5d710df@infradead.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/uartlite.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/uartlite.c +++ b/drivers/tty/serial/uartlite.c @@ -701,7 +701,8 @@ err_uart: static void __exit ulite_exit(void) { platform_driver_unregister(&ulite_platform_driver); - uart_unregister_driver(&ulite_uart_driver); + if (ulite_uart_driver.state) + uart_unregister_driver(&ulite_uart_driver); } module_init(ulite_init);