Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp238081ybg; Thu, 17 Oct 2019 22:09:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwe/+4vYIawen8VwpstRELsuOP1VRse64++93h/yf7gZuPbOSPgLAyXTg8ENqO6N/N1TxzA X-Received: by 2002:aa7:d8d5:: with SMTP id k21mr4686175eds.286.1571375392918; Thu, 17 Oct 2019 22:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571375392; cv=none; d=google.com; s=arc-20160816; b=PKAtL/0oULwmlYQD+Gv5xPCP5QHRy/9jJrsI61h8kJw63/lqvadQ1oGOtjiNPQxWPt Gsf8fEu3yr4X/TUwTZ9BtLirWDZRobiEO4D1bv/ixPseFBSDauK6UYLKTNFnoskk6Ufb nmcgCRIORXdWx7E//qEyqJH+lpD6FUc4CvC7z3NDr8vq/Ghi3d99pUGdPcFCpfUjUFlk OCpGK/c1BHCjO7+ASpJYMXJhkxe99p5vDQgLNQQCQrw62L4YqscdtSMVJr2DaFR1y+Kb YN/rOPCxhHeXr1WOlfvtgPAXSk4prmpPoy1gq/EROBTEtt32D2wVofkj75Fkvnw93LNw YymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1RVyWsFuTtZM8eE6iVAUS1+YAGiy6/4pUeZzeGDbOVQ=; b=fJiJxAi4/VberuDZ9lERdAdYC8rcCelkh3he2IqcJVOv3QlK9xDyeXSTVjwr4wdZuz JsgXix6DZNCWIT0LaaXhk9LDVjkiZ4WJlsTVdHJYI1FYvaeV38IR/DDOmUcqO6BYd9+E pvH9haQR4WBhaqdzt/+shYDag91d5pCrlKs6UbqDnH2Cbvoks+UC/4evT97WKc2k01KT 9FEoRfJEoJp8u8g4goWgKIBRWkPc3NJJSR6EVVvByMWyQnAk4cWGp0Yq3IZevMEWySRP nG7oKbbmvjjI43nhO/rWAi4qQ2u5O2SFqELE9RIpqDh8QAqBM6aIq5L/3yeoTxnAbdVI 1GAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1qbmwoid; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id va9si2758481ejb.126.2019.10.17.22.09.29; Thu, 17 Oct 2019 22:09:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1qbmwoid; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406018AbfJPXX7 (ORCPT + 99 others); Wed, 16 Oct 2019 19:23:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:54032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfJPXX7 (ORCPT ); Wed, 16 Oct 2019 19:23:59 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1F8B20872; Wed, 16 Oct 2019 23:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571268238; bh=igapbZGpLlKRzBdYxMTU1tCbvC2o5pyly0l6ltnqaAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1qbmwoid57B9hFBwPWg+OWygSZUrw22vI6dINmFlY7wSMOPDtrFUs06xMuHrOfJyL QZ7ZMEaGtm0XtCgt0z7sZQ+Tz85DuNq0ousESvViYgloWYilcgjXv2frZXWpVq8rgk 0qbasP5hiEQXf1i2A/Dp9WOzrwqDSIwtOfSZQ0kM= Date: Wed, 16 Oct 2019 16:23:58 -0700 From: Greg Kroah-Hartman To: Mark Brown Cc: Richard Leitner , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksandr Suvorov , Marcel Ziswiler , Igor Opaniuk , Fabio Estevam Subject: Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control Message-ID: <20191016232358.GA994597@kroah.com> References: <20191016214844.038848564@linuxfoundation.org> <20191016214907.599726506@linuxfoundation.org> <20191016220044.GB11473@sirena.co.uk> <20191016221025.GA990599@kroah.com> <20191016223518.GC11473@sirena.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016223518.GC11473@sirena.co.uk> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > > > From: Oleksandr Suvorov > > > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > > > > > This control mute/unmute the ADC input of SGTL5000 > > > > using its CHIP_ANA_CTRL register. > > > > This seems like a new feature and not an obvious candidate for stable? > > > there was a long email from Richard that said: > > Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute > > outputs on probe"), which is e9f621efaebd in v5.3 replaced > > snd_soc_component_write with snd_soc_component_update_bits and > > therefore no longer cleared the MUTE_ADC flag. This caused the > > ADC to stay muted and recording doesn't work any longer. This > > patch fixes this problem by adding a Switch control for > > MUTE_ADC. > > > That's why I took this. If this isn't true, I'll be glad to drop this. > > That's probably not an appropriate fix for stable - it's going to add a > new control which users will need to manually set (or hope their > userspace automatically figures out that it should set for them, more > advanced userspaces like PulseAudio should) which isn't a drop in fix. > You could either drop the backport that was done for zero cross or take > a new patch that clears the MUTE_ADC flag (rather than punting to > userspace to do so), or just be OK with what you've got at the minute > which might be fine given the lack of user reports. Ok, I'll gladly go drop it, thanks! greg k-h