Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932473AbWAFTFR (ORCPT ); Fri, 6 Jan 2006 14:05:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932483AbWAFTFG (ORCPT ); Fri, 6 Jan 2006 14:05:06 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:19107 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S932467AbWAFTEn (ORCPT ); Fri, 6 Jan 2006 14:04:43 -0500 Date: Fri, 6 Jan 2006 20:04:13 +0100 (MET) From: Jan Engelhardt To: Luiz Fernando Capitulino cc: akpm , robert.olsson@its.uu.se, netdev@oss.sgi.com, lkml Subject: Re: [PATCH] pktgen: Adds missing __init. In-Reply-To: <20060106131108.53411909.lcapitulino@mandriva.com.br> Message-ID: References: <20060106131108.53411909.lcapitulino@mandriva.com.br> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 28 >diff --git a/net/core/pktgen.c b/net/core/pktgen.c >index 06cad2d..5eeae0d 100644 >--- a/net/core/pktgen.c >+++ b/net/core/pktgen.c >@@ -2883,7 +2883,7 @@ static int pktgen_add_device(struct pktg > return add_dev_to_thread(t, pkt_dev); > } > >-static struct pktgen_thread *pktgen_find_thread(const char* name) >+static struct pktgen_thread __init *pktgen_find_thread(const char* name) I do not know what CodingStyle says about it (it is correct GCC code), what do the others think of the more often placement of __init as in __init static struct pktgen_thread *pktgen_find_thread(const char *name) or static __init struct pktgen_thread *pktgen_find_thread(const char *name) [depending on what people like] Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/