Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5da7a675.1c69fb81.a888.0911@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20191016143142.28854-1-geert+renesas@glider.be>
References: <20191016143142.28854-1-geert+renesas@glider.be>
From:   Stephen Boyd <swboyd@chromium.org>
To:     Frank Rowand <frowand.list@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Rob Herring <robh+dt@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] of: unittest: Use platform_get_irq_optional() for non-existing interrupt
User-Agent: alot/0.8.1
Date:   Wed, 16 Oct 2019 16:23:32 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Geert Uytterhoeven (2019-10-16 07:31:42)
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 9efae29722588a35..34da22f8b0660989 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1121,7 +1121,7 @@ static void __init of_unittest_platform_populate(vo=
id)
>                 np =3D of_find_node_by_path("/testcase-data/testcase-devi=
ce2");
>                 pdev =3D of_find_device_by_node(np);
>                 unittest(pdev, "device 2 creation failed\n");
> -               irq =3D platform_get_irq(pdev, 0);
> +               irq =3D platform_get_irq_optional(pdev, 0);
>                 unittest(irq < 0 && irq !=3D -EPROBE_DEFER,

This is a test to make sure that irq failure doesn't return probe defer.
Do we want to silence the error message that we're expecting to see?