Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp263997ybg; Thu, 17 Oct 2019 22:40:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqR7gecfCA+sQyo0IhYv92mE9vYnEVVHFnf752ig/HDNZPemlwfcF03Fx4w0HDA5xlgXP/ X-Received: by 2002:a17:906:edb7:: with SMTP id sa23mr7099961ejb.263.1571377240929; Thu, 17 Oct 2019 22:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571377240; cv=none; d=google.com; s=arc-20160816; b=kewyz+c7yt5Nbt3/yYtY/1MFTF3A5n/JRFrnYYcJjflVjNtU5e9pPlp/yJ880AuRCf KhBmSTb+88FkZj3n39nqaeF0h+ZnVSfq9KW3o5JGxSfnhVXIJQBnAEKFisb7gSGb0L8e iiE1ZA+/D99GV6FK/ZQGgibvft8skT09ltg54DjV5o+sijih6Nc19PTrkyBfK2D6sRXm kCfQ8cpsQpVzd04Lt2vKG2ppc1i9mtAXpsiuEeqWIuI5Qbv6fyP2q0z0Es9hdjQHUtOl SaTaF+UUWtl4DYoID259WJZErmwV9R7n5ZBnIg6soRPMh/WJCJ9fiSMflZnodDglBd8w lVBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=nvQ3rKLYcBuvjRA9mbVxHj0zFGjRN8NFx1d63gPtKlI=; b=rkdDfBW3vO7Q3q1D5DreDDyzyKRSdYOXklRaRPqfXdnc8LknRv8kKdnMr5/YA0sxs7 Sd1gbNa5d7vfzzvEp5upgbolOWMF0Kx35N/BPmXbyMqqaugfp6pLbF79g0Q+VlSn9I5M S2XYZVtAflaEZbmrg9YlNuUz1JlZb75tR7TMFwwr6eW2/SZK1VqQiIHCzoYOAT7mbAfu T3vTT4qWDvkCuxEEB/Os1uaZodTZbLK1Vyo1tR60ukDLW8ytfgYQXv/h8ZuJAid1jI+F ILVoYfJZs+jIcH8LFLGhTcbuo3ESnel3foStcX9RZ8DtIVQrEW/+YKB5RxLP32m+DtXm 1JdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Z0pjrXJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20si3252734edc.202.2019.10.17.22.40.17; Thu, 17 Oct 2019 22:40:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Z0pjrXJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394027AbfJQBwg (ORCPT + 99 others); Wed, 16 Oct 2019 21:52:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58152 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391717AbfJQBwg (ORCPT ); Wed, 16 Oct 2019 21:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:In-Reply-To:MIME-Version :Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nvQ3rKLYcBuvjRA9mbVxHj0zFGjRN8NFx1d63gPtKlI=; b=Z0pjrXJuplMgIWNYVGm0gsStj 96vReurUOFmW75uXZh8pz+Mg7oprx62UtnewxZIrn5TVr9eEQYgOI0JSXfpqPjkgl9Z9mkT/ArORr BsyRdC89eZ7KGUzgOKg0Gu5q4o6VLcmI6oMcPwiQTo6lttynxeL7L6+j9AgCwgIEI3GV58HT7+QF9 SEO3Z0/8R10Ufej7U7hVyTKlxWbpjbf4Z4mt3KG8F1YXdzaRkdSZK8tR7jUFl2rOhrsEkjVMPB3CE uKFR3VJ6XmnDN584aT0fbbnQVmVdyU/F/CA9pJ2Nv1eriaqk0699/LBupEjqSCga5Qrsta/v0Z3e+ R+xL0V0mg==; Received: from [2601:1c0:6280:3f0::9ef4] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKuxv-0006Sf-1f; Thu, 17 Oct 2019 01:52:35 +0000 Subject: Re: [PATCH] staging: sm750fb: format description of parameters the to kernel doc format To: gbittencourt , outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, trivial@kernel.org References: <20191017011849.6081-1-gabrielabittencourt00@gmail.com> <799632e2-a328-d72b-397d-3ee6b5e87e06@infradead.org> From: Randy Dunlap Message-ID: Date: Wed, 16 Oct 2019 18:52:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------B227F5DA5237A52E62CCD8AE" Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------B227F5DA5237A52E62CCD8AE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 10/16/19 6:29 PM, gbittencourt wrote: > Hi Randy, > > On 10/16/19 10:25 PM, Randy Dunlap wrote: >> Hi, >> >> On 10/16/19 6:18 PM, Gabriela Bittencourt wrote: >>> Cluster comments that describes parameters of functions and create one >>> single comment before the function in kernel doc format. >> Good plan. >> >> How did you test this patch? > I haven't test it. How can I do it? Hm. There used to be a comment in a (now deleted) document named Documentation/kernel-doc-nano-HOWTO.txt about how to test kernel-doc. I took that comment and made a script from it. I'll attach the script. It's easy to use, but it is made to test only one function or struct or union or enum at a time. You need to have a script named 'kernel-doc' in your PATH or you can specify where the script is located by using $ KERNDOC=path/to/scripts/kernel-doc kdoc_function _parameters_ Its usage is: kdoc_function filename funcname [text|man|html|docbook|xml] where funcname can be a function, struct, union, or enum name. The output format can be any of those listed, but the default is "text". Let me know if you have any questions or problems. >>> Signed-off-by: Gabriela Bittencourt >>> --- >>>   drivers/staging/sm750fb/sm750_accel.c | 65 +++++++++++++++------------ >>>   1 file changed, 37 insertions(+), 28 deletions(-) -- ~Randy --------------B227F5DA5237A52E62CCD8AE Content-Type: text/plain; charset=UTF-8; name="kdoc_function" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kdoc_function" IyEgL2Jpbi9zaAojIGZyb20gbGludXgvRG9jdW1lbnRhdGlvbi9rZXJuZWwtZG9jLW5hbm8t SE9XVE8udHh0CiMgdXNlcyBsaW51eC9zY3JpcHRzL2tlcm5lbC1kb2Mgb3IgYSBjb3B5IG9m IGl0IChpbiAkUEFUSCkuCiMgdXNpbmcgIkxBTkc9QyBvciBMQ19BTEw9QyBrZG9jX2Z1bmN0 aW9uIDxwcm1zPiIgY2FuIGJlIHVzZWZ1bC4KIyBDYW4gdXNlICJLRVJORE9DPTxzY3JpcHRf ZmlsZW5hbWU+IGtkb2NfZnVuY3Rpb24gPHBybXM+IiB0byB2YXJ5CiMgd2hpY2gga2VybmVs LWRvYyBzY3JpcHQgaXMgdXNlZC4KCnZlcmJvc2U9CmRlYnVnPQppZiBbICIkS0VSTkRPQyIg PSAiIiBdOyB0aGVuCglLRVJORE9DPWtlcm5lbC1kb2MKZmkKCiMgY2FyZWZ1bDogbXVzdCBl bnRlciAtdiBiZWZvcmUgLXg6CmlmIFsgIiQxIiA9ICItdiIgXTsgdGhlbgoJdmVyYm9zZT0i LXYiCglzaGlmdApmaQppZiBbICIkMSIgPSAiLXgiIF07IHRoZW4KCWRlYnVnPSIteCIKCXNo aWZ0CmZpCgpmaWxlPSIkMSIKZm49IiQyIgojIGZtdCBjYW4gYmUgInRleHR8bWFufGh0bWx8 ZG9jYm9va3x4bWwiIChkZWZhdWx0IGlzICJ0ZXh0IikKIyBkb2Nib29rIHByb2R1Y2VzIHht bApmbXQ9IiQzIgppZiBbIHgkMyA9IHggXTsgdGhlbgoJZm10PSJ0ZXh0IgpmaQoKaWYgWyAi JDIiID0gIiIgXTsgdGhlbgoJZWNobyAidXNhZ2U6IGtkb2NfZnVuY3Rpb24gZmlsZW5hbWUg ZnVuY25hbWUgW3RleHR8bWFufGh0bWx8ZG9jYm9va3x4bWxdIgoJZXhpdCAxCmZpCgpjYXNl ICRmbXQgaW4KICAgIG1hbikKCSRLRVJORE9DICR2ZXJib3NlICRkZWJ1ZyAtbWFuIC1mdW5j dGlvbiAkZm4gJGZpbGUgfCBucm9mZiAtbWFuIHwgbGVzcwoJOzsKICAgIGh0bWwpCgkkS0VS TkRPQyAkdmVyYm9zZSAkZGVidWcgLWh0bWwgLWZ1bmN0aW9uICRmbiAkZmlsZSA+a2VybmVs ZG9jLmh0bWwKCWVjaG8gInNlZSBrZXJuZWxkb2MuaHRtbCIKCTs7CiAgICBkb2Nib29rfHht bCkKCSRLRVJORE9DICR2ZXJib3NlICRkZWJ1ZyAtZG9jYm9vayAtZnVuY3Rpb24gJGZuICRm aWxlID5rZXJuZWxkb2MueG1sCgllY2hvICJzZWUga2VybmVsZG9jLnhtbCIKCTs7CiAgICAq KQoJJEtFUk5ET0MgJHZlcmJvc2UgJGRlYnVnIC10ZXh0IC1mdW5jdGlvbiAkZm4gJGZpbGUg fCBsZXNzCgk7Owplc2FjCg== --------------B227F5DA5237A52E62CCD8AE--