Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Simon Horman <horms@verge.net.au>
CC:     "linux-kernel@lists.codethink.co.uk" 
        <linux-kernel@lists.codethink.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Subject: RE: [PATCH] usb: renesas_usbhs: fix __le16 warnings
Thread-Topic: [PATCH] usb: renesas_usbhs: fix __le16 warnings
Thread-Index: AQHVg3BX7WaejZzh5Uuo1PfP1tSBgKddMx4AgADnaMA=
Date:   Thu, 17 Oct 2019 02:18:47 +0000
Message-ID: <TYAPR01MB45440369B72F2C994CF8C85FD86D0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
References: <20191015155044.11858-1-ben.dooks@codethink.co.uk>
 <20191016122656.3jpmes4rnz47u5wc@verge.net.au>
In-Reply-To: <20191016122656.3jpmes4rnz47u5wc@verge.net.au>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d8dded65-8466-47ce-f294-08d752a8577d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2019 02:18:47.0600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: umWYp1oHE2jyPWmndTpf82Eq4TlO3XjfPiTgRkcP1M+jNn3ijMsUJxv2a3mqHGXcHtQUixFMTdGRf+HzbhWWbNw+pVswzHc9SlOPngTfOrhDi71fndYetNop06+OmHBu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB3664
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Simon-san,

> From: Simon Horman, Sent: Wednesday, October 16, 2019 9:27 PM
<snip>
> > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_u=
sbhs/common.c
> > index 4c3de777ef6c..a3c30b609433 100644
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -162,17 +162,17 @@ void usbhs_usbreq_get_val(struct usbhs_priv *priv=
, struct usb_ctrlrequest *req)
> >  	req->bRequest		=3D (val >> 8) & 0xFF;
> >  	req->bRequestType	=3D (val >> 0) & 0xFF;
> >
> > -	req->wValue	=3D usbhs_read(priv, USBVAL);
> > -	req->wIndex	=3D usbhs_read(priv, USBINDX);
> > -	req->wLength	=3D usbhs_read(priv, USBLENG);
> > +	req->wValue	=3D cpu_to_le16(usbhs_read(priv, USBVAL));
> > +	req->wIndex	=3D cpu_to_le16(usbhs_read(priv, USBINDX));
> > +	req->wLength	=3D cpu_to_le16(usbhs_read(priv, USBLENG));
>=20
> usbhs_read is backed by readl which performs
> a le->cpu conversion. Rather than have a double conversion
> perhaps it would be nicer to introduce usbhs_read_le.
> Likewise for write.

I'm afraid but, I could not understand these comments.
At the moment, the usbhs_{read,write}() call io{read,write}16(),
not {read,write}l().

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri=
vers/usb/renesas_usbhs/common.c?h=3Dv5.4-rc3#n62

Best regards,
Yoshihiro Shimoda

>=20
> >  }
> >
> >  void usbhs_usbreq_set_val(struct usbhs_priv *priv, struct usb_ctrlrequ=
est *req)
> >  {
> >  	usbhs_write(priv, USBREQ,  (req->bRequest << 8) | req->bRequestType);
> > -	usbhs_write(priv, USBVAL,  req->wValue);
> > -	usbhs_write(priv, USBINDX, req->wIndex);
> > -	usbhs_write(priv, USBLENG, req->wLength);
> > +	usbhs_write(priv, USBVAL,  le16_to_cpu(req->wValue));
> > +	usbhs_write(priv, USBINDX, le16_to_cpu(req->wIndex));
> > +	usbhs_write(priv, USBLENG, le16_to_cpu(req->wLength));
> >
> >  	usbhs_bset(priv, DCPCTR, SUREQ, SUREQ);
> >  }
> > --
> > 2.23.0
> >