Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp284674ybg; Thu, 17 Oct 2019 23:04:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRW5g7aZoKBHNkNaRqoQ1Sr8R800q8S6Lf9cRKaIzAb40qCsJ+aRB/Zt7yFIzs1CGrdXly X-Received: by 2002:a17:906:d8c5:: with SMTP id re5mr7157610ejb.254.1571378661701; Thu, 17 Oct 2019 23:04:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571378661; cv=none; d=google.com; s=arc-20160816; b=xU8TFwJFByPfslw2ogP7oGtRiZHUHVuvfUWexGuxDHhHKPODpzsLPwIXFkLAlD/UC7 IVYhHoFUmbmIkFDWNfD4yonVCQ5kE5GGpdhgYkzubMlLjuJ90dbmJPGibdxFm7liRQbH xbwm8OyJ/UprdwSoCHZz7Os2GkIZtvCaSPCBgSN2e6QPx5blkjGb6H09XRmEXOtui1mp pS3LU1HdY4vDLtn0U346bL7fx4J+tcHJ+r6FB/nEtn5wJzHZyWTHfRKNSTR1Cu58lN4A z8/4iqU/RPlJnIyZiZfCk0L2hXfktKrvfONEZfmUPAa/BMsaMzA+ZHZbgMnkBsUTmDVP KEjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=sy38ZIgCwe6ocp0teR9fIs9+Gi6jyNXlBZcIfAezwGc=; b=QV3Az93oeYWlZtaQvt3KgpDCr0+mFlatYocDZ14qGT9wM5iE6ZRpBEzGIRGKwQlxAu JxxMkrB9RmZErq1Ad77Klm2KxZGYvjxeVHTa/K87gKeynoFNnLLK3DzvAOVmLD8cdqFy IdkmTk2VrxQNeFJpXuPDGKiq5e/kvBYY8RKlbBtRE+LLcEFs/RTkYPSbGuH8y74g0JH5 6PpXW5apBYvwqogxf/emBTwnvzkFUdGL4oA9WuxFDPqPu21G2/viXgjSbO6YM3MPrKLK BgHm5xrUsqLCFBItVGX/niv/5W0XLPgJi1j6rkNukh3X7ef8lyYpB56/4EFFXCcFUbmS TrUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h19si2966852edv.393.2019.10.17.23.03.57; Thu, 17 Oct 2019 23:04:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407631AbfJQD1S (ORCPT + 99 others); Wed, 16 Oct 2019 23:27:18 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:50468 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732869AbfJQD1S (ORCPT ); Wed, 16 Oct 2019 23:27:18 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6D5C04454FFB9CF198AE; Thu, 17 Oct 2019 11:27:16 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Thu, 17 Oct 2019 11:27:09 +0800 Subject: Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations To: David Miller , CC: , , , , References: <1571210231-29154-1-git-send-email-tanhuazhong@huawei.com> <20191016101943.415d73cf@cakuba.netronome.com> <20191016.135003.672960397161023411.davem@davemloft.net> From: tanhuazhong Message-ID: Date: Thu, 17 Oct 2019 11:27:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20191016.135003.672960397161023411.davem@davemloft.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/17 1:50, David Miller wrote: > From: Jakub Kicinski > Date: Wed, 16 Oct 2019 10:19:43 -0700 > >> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: >>> This patch-set includes some bugfixes and code optimizations >>> for the HNS3 ethernet controller driver. >> >> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4 >> should be a separate series targeting the net tree :( > > Agreed, there are legitimate bug fixes. > > I have to say that I see this happening a lot, hns3 bug fixes targetting > net-next in a larger series of cleanups and other kinds of changes. > > Please handle this delegation properly. Send bug fixes as a series targetting > 'net', and send everything else targetting 'net-next'. > Hi, David & Jakub. BTW, patch01 is a cleanup which is needed by patch02, if patch01 targetting 'net-next', patch02 targetting 'net', there will be a gap again. How should I deal with this case? MBR. Huazhong. > . >