Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Mickael GUENE <mickael.guene@st.com>
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: st-mipid02: add a check for
 devm_gpiod_get_optional
Thread-Topic: [PATCH] media: st-mipid02: add a check for
 devm_gpiod_get_optional
Thread-Index: AQHVhBBYvH4VqO4jG0ud7QMMFFTos6deMe0A
Date:   Thu, 17 Oct 2019 05:43:24 +0000
Message-ID: <8de93390-ae04-4278-bb34-aa175c659c23@st.com>
References: <20191016105604.8036-1-hslester96@gmail.com>
In-Reply-To: <20191016105604.8036-1-hslester96@gmail.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.75.127.49]
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <A4E988153FB2A14DB32FDD3556453D02@st.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-17_02:2019-10-17,2019-10-17 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Chuhong,

 Is this check necessary ?
since looking into code it seems to me devm_gpiod_get_optional() can only
return NULL in case of error due to following check in devm_gpiod_get_index=
_optional()
	if (IS_ERR(desc)) {
		if (PTR_ERR(desc) =3D=3D -ENOENT)
			return NULL;
	}
 And in that case reset_gpio is not used

Regards
Mickael

On 10/16/19 12:56, Chuhong Yuan wrote:
> mipid02_probe misses a check for devm_gpiod_get_optional and may miss
> the failure.
> Add a check to fix the problem.
>=20
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/media/i2c/st-mipid02.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid0=
2.c
> index 81285b8d5cfb..d38e888b0a43 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -971,6 +971,9 @@ static int mipid02_probe(struct i2c_client *client)
>  	bridge->reset_gpio =3D devm_gpiod_get_optional(dev, "reset",
>  						     GPIOD_OUT_HIGH);
> =20
> +	if (IS_ERR(bridge->reset_gpio))
> +		return PTR_ERR(bridge->reset_gpio);
> +
>  	ret =3D mipid02_get_regulators(bridge);
>  	if (ret) {
>  		dev_err(dev, "failed to get regulators %d", ret);
> =